Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip on wallet page is retained for unsupported networks. Similar to #19061 #19400

Closed
srirambv opened this issue Nov 12, 2021 · 2 comments · Fixed by brave/brave-core#11225
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Tooltip on wallet page is retained for unsupported networks. Similar to #19061

Steps to Reproduce

  1. Add a custom network
  2. Hover over Buy/Swap tabs on widget
  3. Tooltip is retained

Actual result:

image

Expected result:

Dismiss tooltip when mouse is moved away

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.99 Chromium: 96.0.4664.35 (Official Build) (x86_64)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes, will be once released
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel

@Douglashdaniel Douglashdaniel self-assigned this Nov 22, 2021
@Douglashdaniel Douglashdaniel added this to the 1.34.x - Nightly milestone Nov 23, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 4, 2021
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 21, 2021
@LaurenWags

This comment has been minimized.

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 21, 2021
@srirambv
Copy link
Contributor Author

srirambv commented Jan 3, 2022

Verification passed on

Brave 1.34.77 Chromium: 97.0.4692.56 (Official Build) (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 11 Version Dev (Build 22523.1000)
  • Verified tooltip isn't retained for unsupported network on both page widget and on panel
Buy Widget Sell Widget Buy Panel Sell Panel
image image image image

Verification passed on

Brave 1.34.77 Chromium: 97.0.4692.56 (Official Build) (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 11 Version Dev (Build 22523.1000)
  • Verified tooltip isn't retained for unsupported network on both page widget and on panel
Buy Widget Sell Widget Buy Panel Sell Panel
image image image image

Verification passed on

Brave 1.34.77 Chromium: 97.0.4692.56 (Official Build) (x86_64 translated)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS macOS Version 12.1 (Build 21C52)
  • Verified tooltip isn't retained for unsupported network on both page widget and on panel
Buy Widget Sell Widget Buy Panel Sell Panel
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants