Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display 0x Privacy Policy in Brave Wallet Swap Panel #19392

Closed
Douglashdaniel opened this issue Nov 12, 2021 · 1 comment · Fixed by brave/brave-core#11069
Closed

Display 0x Privacy Policy in Brave Wallet Swap Panel #19392

Douglashdaniel opened this issue Nov 12, 2021 · 1 comment · Fixed by brave/brave-core#11069
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Nov 12, 2021

Description

Display 0x Privacy Policy in the Brave Wallet Swap panel

Screen Shot 2021-11-12 at 12 38 27 PM

@Douglashdaniel Douglashdaniel added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 12, 2021
@Douglashdaniel Douglashdaniel self-assigned this Nov 12, 2021
@bbondy bbondy added this to the 1.32.x - Release milestone Nov 12, 2021
@Douglashdaniel Douglashdaniel changed the title Display 0x Privacy Policy in Brave Wallet Swap and Settings Page Display 0x Privacy Policy in Brave Wallet Swap Panel Nov 12, 2021
@srirambv
Copy link
Contributor

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.318)
☑️ macOS Version 11.5.2
(Build 20G95)
  • Verified test plan from brave/brave-core#11069
  • Verified 0x Privacy policy is shown for Swap feature on both wallet page and widget
  • Verified hover over info icon shows the privacy policy in a tooltip window
  • Verified 0x is hyperlinked to https://0x.org/
Wallet Panel
Wallet Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants