Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enter url should be Enter URL in brave://settings/wallet/networks #19224

Closed
stephendonner opened this issue Nov 3, 2021 · 1 comment · Fixed by brave/brave-core#10873
Closed

Enter url should be Enter URL in brave://settings/wallet/networks #19224

stephendonner opened this issue Nov 3, 2021 · 1 comment · Fixed by brave/brave-core#10873
Assignees
@yrliou
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support needs-text-change This change requires some careful wording. OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.32.x - Release

Comments

@stephendonner
Copy link

Description

Enter url should be Enter URL in brave://settings/wallet/networks

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load brave://settings/wallet/networks
  4. click Add
  5. look at the placeholder Enter url text

Actual result:

Enter url

Screen Shot 2021-11-03 at 3 25 07 PM

Expected result:

Enter URL

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.33.58 Chromium: 95.0.4638.69 (Official Build) nightly (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6.1 (Build 20G224)
@stephendonner stephendonner added bug needs-text-change This change requires some careful wording. polish Nice to have — usually related to front-end/visual tasks feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 3, 2021
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 4, 2021
@yrliou yrliou self-assigned this Nov 4, 2021
@yrliou yrliou mentioned this issue Nov 4, 2021
Merged
24 tasks
@brave-builds brave-builds mentioned this issue Nov 4, 2021
Merged
7 tasks
@stephendonner
Copy link
Author

stephendonner commented Nov 8, 2021 •
edited
Loading

Verified PASSED using

Brave 1.32.94 Chromium: 95.0.4638.69 (Official Build) beta (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new profile
  2. launched Brave
  3. loaded brave://settings/wallet/networks
  4. clicked Add
  5. looked at the placeholder text

Confirmed it now reads Enter URL in brave://settings/wallet/networks

Screen Shot 2021-11-08 at 12 32 07 PM

Verified PASSED using

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Windows 10 Version 20H2 (Build 19042.1288)

image

Verified PASSED using

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Screen Shot 2021-11-15 at 4 17 08 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support needs-text-change This change requires some careful wording. OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging a pull request may close this issue.

Enter url should be Enter URL in brave://settings/wallet/networks brave/brave-core
4 participants
@stephendonner @bbondy @kjozwiak @yrliou