Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave://settings/?search=Speedreader link doesn't auto-scroll to highlighted Speedreader option #19218

Open
stephendonner opened this issue Nov 3, 2021 · 2 comments

Comments

@stephendonner
Copy link

Description

(I wonder if this is an upstream Chromium bug - I quickly tried to find a corollary there before filing.)

brave://settings/?search=Speedreader link doesn't auto-scroll to highlighted Speedreader option

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load an Speedreader-capable article, such as https://www.wired.com/story/ea-sports-might-lose-fifa-and-thats-not-so-bad/
  4. click on the Speedreader icon in the URL bar
  5. in the popup, click on Turn on Speedreader
  6. click again on the Speedreader icon in the URL bar
  7. click on Settings
  8. you're taken to brave://settings/?search=Speedreader
  9. without scrolling or changing the window size, look for the Speedreader entry

The above steps are a good real-world use-case; however, it's just as easy to load brave://settings/?search=Speedreader to reproduce this, for me.

Actual result:

On my MacBook Pro, using Default for display resolution, the Speedreader entry can't be seen without scrolling

Screen Shot 2021-11-03 at 1 32 20 PM

Expected result:

Should auto-scroll the viewport to show the highlighted setting, like so

Screen Shot 2021-11-03 at 1 33 18 PM

Reproduces how often:

100% (for me)

Brave version (brave://version info)

brave://settings/?search=Speedreader link doesn't auto-scroll to Speedreader option

Putting in feature/speedreader for now for triage, but do punt if there's a better component.

@stephendonner
Copy link
Author

Yeah, this is more general of an issue: brave://settings/?search=rewards is affected as well.

example example
Screen Shot 2021-11-03 at 1 47 55 PM Screen Shot 2021-11-03 at 1 47 59 PM

@mkarolin / @petemill any idea if this can be fixed from our side, or know if there is/we need an upstream bug?

@rebron
Copy link
Collaborator

rebron commented Jun 6, 2024

This one looks stale as Speedreader setting was changed. Not able to reproduce step 8.
Screenshot 2024-06-06 at 3 37 11 PM

@rebron rebron closed this as completed Jun 6, 2024
@rebron rebron reopened this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants