Web Store Update URL Missing, causing source-attribution confusion

[jonathansampson]

Description

Extensions installed from the Chrome Web Store are claiming to be not from the web store. This includes extensions like Google Translate and more, which clearly are from the Chrome Web Store.

Steps to Reproduce

1. Install Google Translate
2. Navigate to brave://extensions/
3. Note state of extension

Actual result:

The extension is not properly identified as having originated from the Web Store.

Reproduces how often:

Always.

Brave version (brave://version info)

1.32.84, 1.32.85, 1.33.37

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? No
• Does the issue resolve itself when disabling Brave Rewards? No
• Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

https://github.com/brave/brave-core/blob/9929ff6411a14350dd61fd19a37e93726b44e64d/common/extensions/brave_extensions_client.cc#L47 assumes a kComponentUpdater switch, never falling back on extension_urls::GetDefaultWebstoreUpdateUrl() in its absence.

[stephendonner]

Verified PASSED using

Brave	1.33.58 Chromium: 95.0.4638.69 (Official Build) nightly (x86_64)
Revision	6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS	macOS Version 11.6.1 (Build 20G224)

Steps:

1. new profile
2. launched Brave
3. installed Google Translate
4. opened brave://extensions
5. examined the state of the extension

Confirmed I no longer saw the Not from Web Store. messaging.

default	developer mode

---

Verified PASSED using

Brave	1.33.82 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision	76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS	Windows 10 Version 20H2 (Build 19042.1348)

Steps:

1. new profile
2. launched Brave
3. installed Google Translate
4. opened brave://extensions
5. examined the state of the extension

Confirmed I no longer saw the Not from Web Store. messaging.

default	developer mode

[JimBreton]

FYI it looks like this bug made it into Release 1.32.106.

[jonathansampson]

@JimBreton Apologies; we're working on getting this uplifted and delivered.

[stephendonner]

FYI it looks like this bug made it into Release 1.32.106.

thanks for the heads-up; this should be in the next release of 1.32.x (as soon as we can cut it, with a few other crucial fixes).

[kjozwiak]

Clearing the QA Pass labels. We should re-check this once we get an RC.

[GeetaSarvadnya]

Verification passed on

Brave | 1.32.111 Chromium: 96.0.4664.45 (Official Build) (64-bit)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | Windows 10 Version 21H1 (Build 19043.1348)

• Reproduced the issue in 1.32.106
• Verified the STR from the description and ensured Not from Web Store messaging is not shown in brave://extensions/ in 1.32.111

1.32.106	1.32.111

---

Verified passed with

Brave | 1.32.111 Chromium: 96.0.4664.45 (Official Build) (x86_64)
-- | --
Revision | 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS | macOS Version 11.6.1 (Build 20G224)

• Reproduced the issue in 1.32.106
• Verified the STR from the description and ensured Not from Web Store messaging is not shown in brave://extensions/ in 1.32.111
• Verified in both clean and upgrade profiles

1.32.106	1.32.111

---

Verification passed on

Brave	1.32.112 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision	76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS	Ubuntu 18.04 LTS