Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual test run on macOS (arm64) for Tor 1.0.21 #19045

Closed
9 tasks done
kjozwiak opened this issue Oct 27, 2021 · 1 comment
Closed
9 tasks done

Manual test run on macOS (arm64) for Tor 1.0.21 #19045

kjozwiak opened this issue Oct 27, 2021 · 1 comment

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Oct 27, 2021

Tor Client Updater

  • For development go-update-server. Run brave-browser with --user-data-dir=component-dev --use-dev-goupdater-url (These flags are only available in v1.7.x). Once the crx is pushed to production run without these flags.
  • Navigate to brave://components and verify Tor Client Updater (OS) is updated successfully.
  • Open New Private Window with Tor and confirm that it starts without any errors.
    • Navigate to check.torproject.org and verify that tor is working successfully.
    • Navigate to brave.com and http://3g2upl4pq6kufc4m.onion/ to check if the sites work correctly.
  • Load brave.com and mail.protonmail.com in a regular Window/Tab and ensure that clicking on Open in Tor correctly launches a Tor window and opens the appropriate .onion website.

MacOS

  • Navigate to /Users/<user>/Library/Application Support/BraveSoftware/Brave-Browser-<channel>/cldoidikboihgcjfkhdeidbpclkineef/<version>
  • Run codesign -vvvv tor-<version-tor>-darwin-brave-<version-brave> to confirm codesign is valid
  • For MacOS Catalina (10.15+) - Run spctl -a -vv -t install tor-<version-tor>-darwin-brave-<version-brave> to verify that the binary is notarized.
@stephendonner
Copy link

stephendonner commented Nov 10, 2021

Verified PASSED on macOS Big Sur 11.6 arm64 with the following build:

Brave 1.31.91 Chromium: 95.0.4638.69 (Official Build) (arm64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6 (Build 20G165)

Confirmed that codesign is valid:

stephendonner@Stephens-MBP-3 1.0.34 % codesign -vvv tor-0.4.5.11-darwin-brave-0
tor-0.4.5.11-darwin-brave-0: valid on disk
tor-0.4.5.11-darwin-brave-0: satisfies its Designated Requirement

Confirmed that the binary is notarized:

stephendonner@Stephens-MBP-3 1.0.34 % spctl -a -vv -t install tor-0.4.5.11-darwin-brave-0
objc[35863]: Class SPExecutionPolicy is implemented in both /System/Library/PrivateFrameworks/SystemPolicy.framework/Versions/A/SystemPolicy and /usr/sbin/spctl. One of the two will be used. Which one is undefined.
objc[35863]: Class AppWrapper is implemented in both /System/Library/PrivateFrameworks/SystemPolicy.framework/Versions/A/SystemPolicy and /usr/sbin/spctl. One of the two will be used. Which one is undefined.
objc[35863]: Class AppWrapperPolicyResult is implemented in both /System/Library/PrivateFrameworks/SystemPolicy.framework/Versions/A/SystemPolicy and /usr/sbin/spctl. One of the two will be used. Which one is undefined.
objc[35863]: Class AppWrapperPolicy is implemented in both /System/Library/PrivateFrameworks/SystemPolicy.framework/Versions/A/SystemPolicy and /usr/sbin/spctl. One of the two will be used. Which one is undefined.
objc[35863]: Class SPLog is implemented in both /System/Library/PrivateFrameworks/SystemPolicy.framework/Versions/A/SystemPolicy and /usr/sbin/spctl. One of the two will be used. Which one is undefined.
objc[35863]: Class MIS is implemented in both /System/Library/PrivateFrameworks/SystemPolicy.framework/Versions/A/SystemPolicy and /usr/sbin/spctl. One of the two will be used. Which one is undefined.
objc[35863]: Class SPExecutionHistoryItem is implemented in both /System/Library/PrivateFrameworks/SystemPolicy.framework/Versions/A/SystemPolicy and /usr/sbin/spctl. One of the two will be used. Which one is undefined.
objc[35863]: Class SPExecutionPolicyItem is implemented in both /System/Library/PrivateFrameworks/SystemPolicy.framework/Versions/A/SystemPolicy and /usr/sbin/spctl. One of the two will be used. Which one is undefined.
objc[35863]: Class SPDeveloperPolicy is implemented in both /System/Library/PrivateFrameworks/SystemPolicy.framework/Versions/A/SystemPolicy and /usr/sbin/spctl. One of the two will be used. Which one is undefined.
objc[35863]: Class GKScanResult is implemented in both /System/Library/PrivateFrameworks/SystemPolicy.framework/Versions/A/SystemPolicy and /usr/sbin/spctl. One of the two will be used. Which one is undefined.
tor-0.4.5.11-darwin-brave-0: accepted
source=Notarized Developer ID
origin=Developer ID Application: Brave Software, Inc. (KL8N8XSYF4)

Confirmed that the Tor component was started when launching Tor and ensured Tor 0.4.5.11 was being used:

Nov 10 08:02:44.696 [notice] Tor 0.4.5.11 running on Darwin with Libevent 2.1.11-stable, OpenSSL 1.1.1l, Zlib 1.2.11, Liblzma N/A, Libzstd N/A and Unknown N/A as libc.
Nov 10 08:02:44.696 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Nov 10 08:02:44.696 [notice] Configuration file "/nonexistent" not present, using reasonable defaults.
Nov 10 08:02:44.697 [notice] Opening Socks listener on 127.0.0.1:0
Nov 10 08:02:44.697 [notice] Socks listener listening on port 62348.
Nov 10 08:02:44.697 [notice] Opened Socks listener connection (ready) on 127.0.0.1:62348
Nov 10 08:02:44.697 [notice] Opening Control listener on 127.0.0.1:0
Nov 10 08:02:44.697 [notice] Control listener listening on port 62349.
Nov 10 08:02:44.697 [notice] Opened Control listener connection (ready) on 127.0.0.1:62349
[35904:28163:1110/080244.697528:INFO:tor_file_watcher.cc(183)] tor: failed to open control auth cookie
[35904:28163:1110/080244.697689:INFO:tor_file_watcher.cc(183)] tor: failed to open control auth cookie
[35904:28163:1110/080244.699076:INFO:tor_file_watcher.cc(183)] tor: failed to open control auth cookie
Nov 10 08:02:44.000 [notice] Bootstrapped 0% (starting): Starting
Nov 10 08:02:44.000 [notice] Starting with guard context "default"
Nov 10 08:02:44.000 [notice] New control connection opened from 127.0.0.1.
Nov 10 08:02:44.000 [notice] Bootstrapped 5% (conn): Connecting to a relay
Nov 10 08:02:45.000 [notice] Bootstrapped 10% (conn_done): Connected to a relay
Nov 10 08:02:45.000 [notice] Bootstrapped 14% (handshake): Handshaking with a relay
Nov 10 08:02:45.000 [notice] Bootstrapped 15% (handshake_done): Handshake with a relay done
Nov 10 08:02:45.000 [notice] Bootstrapped 75% (enough_dirinfo): Loaded enough directory info to build circuits
Nov 10 08:02:45.000 [notice] Bootstrapped 90% (ap_handshake_done): Handshake finished with a relay to build circuits
Nov 10 08:02:45.000 [notice] Bootstrapped 95% (circuit_create): Establishing a Tor circuit
Nov 10 08:02:46.000 [notice] Bootstrapped 100% (done): Done

Screen Shot 2021-11-10 at 8 04 00 AM

Confirmed that you can open the following domains in a Tor window without issues:

brave.com
duckduckgo.com
https://duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad.onion/
check.torproject.org (ensured that hard refreshing gets a new circuit/IP)

Confirmed the following sites opened via “Open in Tor” button and navigated to .onion URL:

brave.com --> https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/
mail.protonmail.com --> https://protonmailrmez3lotccipshtkleegetolb73fuirgj7r4o4vfu7ozyd.onion
nytimes.com --> https://www.nytimesn7cgmftshazwhfgzm37qxb44r64ytbb2dj3x62d2lljsciiyd.onion/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants