Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show confirmation of resetting wallet #18997

Closed
srirambv opened this issue Oct 26, 2021 · 3 comments · Fixed by brave/brave-core#11669
Closed

Show confirmation of resetting wallet #18997

srirambv opened this issue Oct 26, 2021 · 3 comments · Fixed by brave/brave-core#11669
Assignees
Labels

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 26, 2021

Description

Currently we only show the confirmation before resetting the wallet. When you type 'yesinstead ofYes` the wallet doesn't reset and there is no confirmation about whether reset was a success or failure

Steps to Reproduce

  1. Go to brave://settings/wallet
  2. Click on Reset wallet
  3. Type yes and click enter, modal closes wallet isn't reset and there is no confirmation of it
  4. Click Reset wallet again
  5. Type Yes and click ok. Wallet is reset but no confirmation

Actual result:

No confirmation of a successful/failure in resetting the wallet

Expected result:

Should show a confirmation of success

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.33.32 Chromium: 95.0.4638.54 (Official Build) nightly (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @bbondy @jamesmudgett

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 29, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 3, 2021
@bbondy bbondy self-assigned this Dec 20, 2021
@bbondy bbondy changed the title Show confirmation of successful/failure in resetting wallet Show confirmation of resetting wallet Dec 21, 2021
@bbondy bbondy added this to the 1.35.x - Nightly milestone Dec 28, 2021
@stephendonner
Copy link

Verified PASSED using

Brave 1.35.69 Chromium: 97.0.4692.56 (Official Build) dev (x86_64)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new profile
  2. launched Brave
  3. clicked on the wallet icon on the browser toolbar
  4. clicked Get Started
  5. entered a password, twice
  6. went through code words (12)
  7. confirmed my empty wallet was created
  8. loaded brave://settings/wallet
  9. clicked on Wallet
  10. clicked on Reset Wallet
  11. typed Yes and clicked OK (confirmed other responses silently failed, closing the dialog)
  12. confirmed my wallet -- in the other tab -- was now reset
example example example
Screen Shot 2021-12-30 at 1 45 50 PM Screen Shot 2021-12-30 at 1 45 57 PM Screen Shot 2021-12-30 at 1 46 03 PM

@kjozwiak
Copy link
Member

kjozwiak commented Jan 7, 2022

Removing QA Pass-macOS as this was reverted from 1.35.x and will need to be retested with 1.36.x just in case 👍

@srirambv
Copy link
Contributor Author

Brave 1.36.90 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified successfully reset message is shown once wallet is reset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants