-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave News should be a c++ browser-side API that can be usable from Android Java and WebUI JS #18787
Comments
Verification passed on
Clean profileCase 1: Feed renders and Images render
Case 2: Promoted items render
Promoted content Ad
Case 3: Sources can be switched off and on by the user/Feed refreshes and removes sources from user-disabled sources
Case 4: Repeating order of cards are the same
Case 5: Display Ads render occasionally
Inline Content Ad
Case 6: "Deals" render
Case 7: Feed refreshes periodically through the day
Upgrade profileCase 1: Enable brave news in 1.32.x and disable it and upgrade profile to 1..33.x
Case 2: Enable brave news in 1.32.x and disable a few default publishers via Sources and then disable brave news and upgrade profile to 1.33.x
Case 3: Verify feed fetch_enable brave news in 1.32.x and disable it, set the device clock ahead by one hour and upgrade profile to 1.33.x and enable brave news
Case 4: Enable brave news 1.32.x and view Inline content ad and promoted content ad, disable brave news and upgrade profile to 1.33.x and enable brave news
Additional checks
Verified
Clean profileCase 1: Feed renders and Images render
Case 2: Promoted-content items render
Promoted-content Ad
Case 3: Sources can be switched off and on by the user; Feed refreshes and removes sources from user-disabled sources
Case 4: Repeating order of cards are the same
Case 5: Display Ads render occasionally
Inline-Content Ad
Case 6: "Deals" cards render
Filed #19658
Case 7: Feed refreshes periodically throughout the day
Upgrade profileCase 1: Enable Brave News in 1.32.x, disable it, and then upgrade profile to 1.33.x
Case 2: Enable Brave News in 1.32.x and disable a few default publishers via `Sources` and then disable Brave News and upgrade profile to 1.33.x
Case 3: Verify feed fetch_enable Brave News in 1.32.x and disable it, set the device clock ahead by three (3) hours, upgrade the profile to 1.33.x and enable Brave News
Case 4: Enable brave news 1.32.x and view Inline content ad and promoted content ad, disable brave news and upgrade profile to 1.33.x and enable brave news
Additional checks
Verification passed on
Verified as part of #18843 |
For Android: QA should confirm that Brave News is not available on 1.33.x (per https://bravesoftware.slack.com/archives/C0816QH3R/p1638550052373600?thread_ts=1638549875.371900&cid=C0816QH3R) cc @brave/legacy_qa |
Verified using Pixel 3 XL with Android 11 running 1.33.100. Per https://bravesoftware.slack.com/archives/C0816QH3R/p1638551089375400?thread_ts=1638549875.371900&cid=C0816QH3R, executed tests from brave/brave-core#11121 (comment).
|
Description
Move Brave News fetching and parsing from Extension background page to c++ browser side Mojom API.
All Brave News functionality should be exactly the same before and after.
Test Plan
The text was updated successfully, but these errors were encountered: