Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject cosmetic scriptlets and filters synchronously on page loading #18301

Closed
antonok-edm opened this issue Sep 23, 2021 · 0 comments · Fixed by brave/brave-core#10214
Closed

Comments

@antonok-edm
Copy link
Collaborator

We've had a few instances in which websites have updated their code such that a script runs before Brave has a chance to inject a scriptlet from cosmetic filtering. This has caused YouTube and more recently iCloud to break spectacularly.

We should block the page load on these scriptlets being available. It shouldn't cause any significant delay, particularly if we optimize the current code which has a few unnecessary thread jumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant