-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message for IPFS gateway without Origin isolation #18212
Milestone
Comments
24 tasks
Verified
Steps:
Confirmed we now see |
This was referenced Mar 2, 2022
This was referenced Jun 21, 2022
This was referenced Sep 12, 2022
This was referenced Oct 19, 2022
This was referenced Nov 29, 2022
This was referenced Feb 8, 2023
This was referenced Apr 17, 2023
This was referenced Jun 6, 2023
This was referenced Jul 11, 2023
This was referenced Sep 7, 2023
This was referenced Oct 10, 2023
This was referenced Nov 16, 2023
This was referenced Feb 7, 2024
This was referenced Apr 4, 2024
This was referenced Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
UX problem
A check was introduced in #16999 that blocks use of gateways without Origin isolation:
The error message "Invalid gateway address" is bit confusing, because
ipfs.io
is a valid gateway, it is just insecure when used for loading websites that expect Origin isolation.Proposed fix
I suggest renaming the error message to something long in the lines of "Only a valid IPFS gateway with Origin isolation enabled can be used in Brave"
cc @spylogsster
The text was updated successfully, but these errors were encountered: