Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include web-discovery-project in Brave #18166

Closed
kkuehlz opened this issue Sep 16, 2021 · 1 comment · Fixed by brave/brave-core#9381
Closed

Include web-discovery-project in Brave #18166

kkuehlz opened this issue Sep 16, 2021 · 1 comment · Fixed by brave/brave-core#9381

Comments

@kkuehlz
Copy link
Contributor

kkuehlz commented Sep 16, 2021

--
The Web Discovery Project is intended to make Brave Search more relevant and useful for everyone.

It is a strictly opt-in feature.

Data collection in Web Discovery Project is done in a privacy preserving fashion. By default, it discards search queries that are too long or suspicious looking (e.g. those that include phone numbers). It also discards odd URLs (e.g. those containing hashes), URLs of pages with a no-index flag, and pages that are not public or require any sort of authentication.

The system is designed so that no data received can be linked back to individuals or their devices. For a URL to be sent it needs to be visited independently by a large number of people. All data received is unlinkable, making it impossible to build profiles or sessions of Web Discovery Project contributors.

The PR is including the bundles that can be found on the Web discovery project public repo

Further materials,

@stephendonner
Copy link

stephendonner commented Sep 27, 2021

Verified PASSED using

Brave 1.31.62 Chromium: 94.0.4606.54 (Official Build) beta (x86_64)
Revision c8191a1d5cccbf64e8fe7269043f8ace8d74dd05-refs/branch-heads/4606@{#1130}
OS macOS Version 11.6 (Build 20G165)

Went through and verified the STR/Cases outlined via brave/brave-core#9381 (comment) as per the following:

  • ensured that Web Discovery Project is disabled by default via brave://settings/search
  • ensured that clicking on Learn more opens https://brave.com/privacy/browser/#web-discovery-project without any issues
  • ensured that WDP.isRunning returns false when Web Discovery Project is disabled
  • ensured that WDP.isRunning returns true when Web Discovery Project is enabled
WDP.isRunning = false WDP.isRunning = true
Screen Shot 2021-09-27 at 3 13 24 PM Screen Shot 2021-09-27 at 3 14 13 PM
  • ensured that WDP.isRunning stays true if enabled after restarting the browser several times
  • ensured that WDP.isRunning stays false if disabled after restarting the browser several times
  • ensured that an error was displayed via the browser console when using WDP.modules['web-discovery-project'].background.webDiscoveryProject.patternsLoader.resourceWatcher.forceUpdate() but WDP.isRunning is false
  • ensured that WDP.modules['web-discovery-project'].background.webDiscoveryProject.patternsLoader.resourceWatcher.forceUpdate() displayed the correct data when WDP.isRunning is enabled/appearing as true
Disabled Output Enabled Output
Screen Shot 2021-09-29 at 2 15 12 PM Screen Shot 2021-09-27 at 3 18 22 PM

Screen Shot 2021-09-27 at 3 20 11 PM

  • waited ~10min once WDP was disabled after confirming that WDP.isRunning is false and ensured that no calls to wdp.brave.com occurred

Verification passed on

Brave | 1.31.66 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
-- | --
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Went through and verified the STR/Cases outlined via brave/brave-core#9381 (comment) as per the following:

  • ensured that Web Discovery Project is disabled by default via brave://settings/search
  • ensured that clicking on Learn more opens https://brave.com/privacy/browser/#web-discovery-project without any issues
  • ensured that WDP.isRunning returns false when Web Discovery Project is disabled
  • ensured that WDP.isRunning returns true when Web Discovery Project is enabled
WDP.isRunning = false WDP.isRunning = true
image image
  • ensured that WDP.isRunning stays true if enabled after restarting the browser several times
  • ensured that WDP.isRunning stays false if disabled after restarting the browser several times
  • ensured that an error was displayed via the browser console when using WDP.modules['web-discovery-project'].background.webDiscoveryProject.patternsLoader.resourceWatcher.forceUpdate() but WDP.isRunning is false
  • ensured that WDP.modules['web-discovery-project'].background.webDiscoveryProject.patternsLoader.resourceWatcher.forceUpdate() displayed the correct data when WDP.isRunning is enabled/appearing as true
Disabled Output Enabled Output
image image
  • Open a new tab in the browser and visit the following Google SERP: https://www.google.com/search?q=joker
  • Close the tab once the page has fully loaded and go back to the console devtool.
  • Run the following command:
    WDP.modules['web-discovery-project'].background.webDiscoveryProject.strictQueries.map(x=>x.tDiff=0)
  • Wait up to ~20 seconds and you should see network requests being emitted like in the screenshot below (one or more calls to https://collector.wdp.brave.com/.)
    image
  • waited ~10min once WDP was disabled after confirming that WDP.isRunning is false and ensured that no calls to wdp.brave.com occurred

Verified PASSED using

Brave 1.31.66 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
Revision 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS Linux

Went through and verified the STR/Cases outlined via brave/brave-core#9381 (comment) as per the following:

  • ensured that Web Discovery Project is disabled by default via brave://settings/search
  • ensured that clicking on Learn more opens https://brave.com/privacy/browser/#web-discovery-project without any issues
  • ensured that WDP.isRunning returns false when Web Discovery Project is disabled
  • ensured that WDP.isRunning returns true when Web Discovery Project is enabled
WDP.isRunning = false WDP.isRunning = true
Screen Shot 2021-09-29 at 1 51 35 PM Screen Shot 2021-09-29 at 1 51 58 PM
  • ensured that WDP.isRunning stays true if enabled after restarting the browser several times
  • ensured that WDP.isRunning stays false if disabled after restarting the browser several times
  • ensured that an error was displayed via the browser console when using WDP.modules['web-discovery-project'].background.webDiscoveryProject.patternsLoader.resourceWatcher.forceUpdate() but WDP.isRunning is false
  • ensured that WDP.modules['web-discovery-project'].background.webDiscoveryProject.patternsLoader.resourceWatcher.forceUpdate() displayed the correct data when WDP.isRunning is enabled/appearing as true
Disabled Output Enabled Output
Screen Shot 2021-09-29 at 2 04 26 PM Screen Shot 2021-09-29 at 2 05 18 PM
  • waited ~10min once WDP was disabled after confirming that WDP.isRunning is false and ensured that no calls to wdp.brave.com occurred

Screen Shot 2021-09-29 at 2 20 46 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 27, 2021
@rebron rebron changed the title Include web-discovery-project in brave Include web-discovery-project in Brave Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment