Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text on Reset page of Manage Your Wallet more custodian neutral #18105

Closed
Miyayes opened this issue Sep 14, 2021 · 1 comment · Fixed by brave/brave-core#10520
Closed
Assignees
Labels

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 14, 2021

Description

On "Reset" page, language points to Gemini instead of verifying the wallet more generally.

image

Solution

Just say:

Your 0.25 BAT and other Rewards data will be permanently lost if you reset your wallet. Please ensure you have verified your wallet so you can keep your BAT.

If possible, make "verified your wallet" string a hyperlink that opens the verify wallet/custodian selection modal.


Notes: This is similar to #18014.

@stephendonner
Copy link

stephendonner commented Oct 25, 2021

Verified PASSED using

Brave 1.33.32 Chromium: 95.0.4638.54 (Official Build) nightly (x86_64)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging
  3. opened a new-tab page
  4. clicked on Start using Rewards
  5. clicked on Claim my Rewards
  6. opened brave://rewards
  7. clicked on Manage your wallet
  8. clicked on the Reset tab

Confirmed the text now reads "Your 30 BAT and other Rewards data will be permanently lost if you reset your wallet. Please ensure you have verified your wallet so you can keep your BAT."

Confirmed verified your wallet is now a link to the Verifying is optional pane.

before after verified your wallet
Screen Shot 2021-10-25 at 11 27 30 AM Screen Shot 2021-10-25 at 11 27 34 AM Screen Shot 2021-10-25 at 11 27 38 AM

Also tested with Japan region for bitFlyer; got the same generic messaging:

Screen Shot 2021-10-25 at 18 55 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants