Crashed while changing theme type (cr94)

[simonhong]

Got crash while changing theme type from settings page.

[10675:259:0914/082208.023884:FATAL:brave_appearance_handler.cc(72)] Check failed: args[0].is_int().
0   libbase.dylib                       0x0000000108929009 base::debug::CollectStackTrace(void**, unsigned long) + 9
1   libbase.dylib                       0x00000001087fbec3 base::debug::StackTrace::StackTrace() + 19
2   libbase.dylib                       0x00000001088220ff logging::LogMessage::~LogMessage() + 175
3   libbase.dylib                       0x000000010882307e logging::LogMessage::~LogMessage() + 14
4   libchrome_dll.dylib                 0x00000001121b3433 BraveAppearanceHandler::SetBraveThemeType(base::ListValue const*) + 211
5   libcontent.dylib                    0x000000010e89d917 content::WebUIImpl::ProcessWebUIMessage(GURL const&, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > const&, base::ListValue const&) + 135
6   libcontent.dylib                    0x000000010dce9a85 content::mojom::WebUIHostStubDispatch::Accept(content::mojom::WebUIHost*, mojo::Message*) + 453
7   libbindings.dylib                   0x00000001094f54c3 mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*) + 627
8   libbindings.dylib                   0x00000001094fc52f mojo::MessageDispatcher::Accept(mojo::Message*) + 271
9   libbindings.dylib                   0x00000001094f713a mojo::InterfaceEndpointClient::HandleIncomingMessage(mojo::Message*) + 154
10  libipc.dylib                        0x000000010b1da066 IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnEndpointThread(mojo::Message) + 710
11  libipc.dylib                        0x000000010b1d6ccc base::internal::Invoker<base::internal::BindState<void (IPC::(anonymous namespace)::ChannelAssociatedGroupController::*)(mojo::Message), scoped_refptr<IPC::(anonymous namespace)::ChannelAssociatedGroupController>, mojo::Message>, void ()>::RunOnce(base::internal::BindStateBase*) + 140

[GeetaSarvadnya]

@simonhong Is this macOS specific issue? As I don't see the crash in windows.

[simonhong]

@GeetaSarvadnya This could happen on all desktops. Which version did you try?
This is fixed since v1.31.40.

[GeetaSarvadnya]

@simonhong Got it Thanks. I have tried on 1.31.41

[GeetaSarvadnya]

Verification passed on

Brave | 1.30.80 Chromium: 94.0.4606.50 (Official Build) beta (64-bit)
-- | --
Revision | 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS | Windows 10 Version 21H1 (Build 19043.1165)

• Confirmed there is no crash when the theme is changed to Dark/Light/Same as windows

Dark theme	Light theme	Same as Windows

---

Verification PASSED using

Brave	1.30.81 Chromium: 94.0.4606.50 (Official Build) (64-bit)
Revision	0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS	Linux

Steps:

1. new profile
2. launched Brave
3. opened brave://settings/appearance
4. chose Dark, and Light from Brave colors

Confirmed 1) I was able to dynamically switch between all 3 values without crashing, 2) theme changes applied, and 3) no crashes 4) did this for both Classic and GTK+ system themes.

example	example	example	example

Verified PASSED using

Brave	1.30.81 Chromium: 94.0.4606.50 (Official Build) (x86_64)
Revision	0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS	macOS Version 11.6 (Build 20G165)

Steps:

1. new profile
2. launched Brave
3. opened brave://settings/appearance
4. chose same as macOS, Dark, and Light from Brave colors

Confirmed 1) I was able to dynamically switch between all 3 values without crashing, 2) theme changes applied, and 3) no crashes

example	example	example