Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid gateway address message is shown when https://localhost:{any port} is set in IPFS gateway #17966

Closed
GeetaSarvadnya opened this issue Sep 9, 2021 · 1 comment

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #16999

Steps to Reproduce

  1. Clean profile 1.30.68
  2. launch Brave
  3. load brave://settings/ipfs
  4. click on the Change button
  5. enter https://localhost:48083 and click Submit

Actual result:

Invalid gateway address error message is returned.

image

Expected result:

It should work as it works in 1.29.79

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.30.68 Chromium: 93.0.4577.63 (Official Build) beta (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Windows 10 OS Version 2009 (Build 19043.1165)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @spylogsster

@spylogsster
Copy link

@GeetaSarvadnya we check what will that gateway respond for predefined ipfs url, if it has wrong response we alert it as invalid, so to setup localhost url that localhost should resolve ipfs correctly, more details here #16999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants