Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending tips for Gemini creators not sent when switching from Uphold to Gemini #17766

Closed
LaurenWags opened this issue Aug 30, 2021 · 3 comments · Fixed by brave/brave-core#10324

Comments

@LaurenWags
Copy link
Member

Description

If a user changes their custodial wallet from Uphold to Gemini, pending tips that were earmarked for a Gemini creator are not being sent out once the change to Gemini is made.

Steps to Reproduce

  1. Have a profile w/ Uphold KYC'd user wallet
  2. Tip a Gemini verified creator
  3. Confirm the tip goes to the pending tips list
  4. Disconnect from Uphold and connect KYC'd Gemini wallet

Actual result:

Pending tip is not sent to the Gemini creator, it remains in the pending list. I tried the following per suggestions to get this to happen:

  • refreshing the publisher list (manually from panel)
  • advancing computer clock 1 day
  • advancing computer clock 3 days

Screen Shot 2021-08-30 at 12 42 03 PM

Expected result:

At some point the pending tip for Gemini creator should be sent out

Reproduces how often:

easily

Brave version (brave://version info)

1.29.75

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.28.x n/a, 1.29.x yes
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the nightly channel? 1.31.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @Miyayes @jumde @rebron

@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 26, 2021

Verified using

Brave | 1.32.81 Chromium: 95.0.4638.54 (Official Build) beta (x86_64)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | macOS Version 11.6 (Build 20G165)
Clean Profile - PASSED

Per brave/brave-core#10324 (comment), confirmed database migration (v1 -> v33) is successful.
Also confirmed there's no processor column in the pending_contribution table.

Example Example
Clean1 Clean2
Upgrade Profile - PASSED

Installed 1.31.87 and enabled Rewards.
Confirmed DB version is 32 and there is a processor column in the pending_contribution table.

Example Example
1 31 x 1 1 31 x 2

Upgraded to 1.32.81 by renaming the profile.
Per brave/brave-core#10324 (comment), confirmed database migration (v32 -> v33) is successful. (note, DB migration in logs shows 33->33. Discussed this with Szilard and he confirmed that previous migrations also showed this way in the logs)
Also confirmed there's no processor column in the pending_contribution table.

Example Example
Upgrade1 Upgrade2
Uphold --> Gemini wallet change - PASSED

Verified test plan from brave/brave-core#10324 (comment)

Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:

Example Example
Step3a Step3b

Confirmed able to disconnect from Uphold and connect Gemini account per step 4:
Step4

Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel:
Step5

I checked the logs and saw that the tip was now being initiated.

Step 6 logs
[24776:259:1029/153547.366913:VERBOSE1:contribution.cc(362)] Creating contribution for wallet type gemini (amount: 5, type: ONE_TIME_TIP)
[24776:259:1029/153547.371895:VERBOSE1:contribution.cc(91)] Queue timer set for 4 s
[24776:259:1029/153547.372778:VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
[24776:259:1029/153547.374482:INFO:post_transaction_gemini.cc(103)] Initiating gemini transaction to: 60ec69b1-f02c-467e-9247-8c174c49eb95for 4.75
[24776:259:1029/153547.374554:VERBOSE5:ledger_impl.cc(119)] 
[ REQUEST ]
> URL: https://api.qa6.aurora7.net/v1/payments/pay
> Method: POST
> Content Type: application/json; charset=utf-8
[24776:259:1029/153547.578822:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api.qa6.aurora7.net/v1/payments/pay
> Result: Success
> HTTP Code: 200
> Body: {"result":"OK","tx_ref":"20afec3a-acd7-46fe-9f21-60ce0dd8d76a","amount":4.75,"currency":"BAT","destination":"60ec69b1-f02c-467e-9247-8c174c49eb95","status":"Pending"}
[24776:259:1029/153547.578926:VERBOSE9:logging_util.cc(137)] 
[ RESPONSE HEADERS ]
> Url: https://api.qa6.aurora7.net/v1/payments/pay
[24776:259:1029/153547.579995:INFO:post_transaction_gemini.cc(116)] Gemini transaction successful
[24776:259:1029/153547.580062:VERBOSE1:post_transaction_gemini.cc(129)] Transfer Pending
[24776:259:1029/153547.580110:VERBOSE1:gemini_transfer.cc(75)] Will fetch transaction status after 3 minutes
[24776:259:1029/153847.581809:VERBOSE1:gemini_transfer.cc(86)] Fetching transaction status 1 time
[24776:259:1029/153847.582320:VERBOSE5:ledger_impl.cc(119)] 
[ REQUEST ]
> URL: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/20afec3a-acd7-46fe-9f21-60ce0dd8d76a
> Method: GET
> Content Type: application/json; charset=utf-8
[24776:259:1029/153847.760784:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/20afec3a-acd7-46fe-9f21-60ce0dd8d76a
> Result: Success
> HTTP Code: 200
> Body: {"tx_ref":"20afec3a-acd7-46fe-9f21-60ce0dd8d76a","amount":4.75,"currency":"BAT","destination":"60ec69b1-f02c-467e-9247-8c174c49eb95","status":"Pending"}
[24776:259:1029/153847.760896:VERBOSE9:logging_util.cc(137)] 
[ RESPONSE HEADERS ]
> Url: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/20afec3a-acd7-46fe-9f21-60ce0dd8d76a
[24776:259:1029/153847.760959:VERBOSE1:get_transaction_gemini.cc(88)] Transfer Status: Pending
[24776:259:1029/153847.762090:INFO:gemini_transfer.cc(104)] Number of active retry timers: 0
[24776:259:1029/153847.762174:VERBOSE1:gemini_transfer.cc(75)] Will fetch transaction status after 6 minutes
[24776:259:1029/154447.766104:VERBOSE1:gemini_transfer.cc(86)] Fetching transaction status 2 time
[24776:259:1029/154447.767313:VERBOSE5:ledger_impl.cc(119)] 
[ REQUEST ]
> URL: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/20afec3a-acd7-46fe-9f21-60ce0dd8d76a
> Method: GET
> Content Type: application/json; charset=utf-8
[24776:259:1029/154447.948088:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/20afec3a-acd7-46fe-9f21-60ce0dd8d76a
> Result: Success
> HTTP Code: 200
> Body: {"tx_ref":"20afec3a-acd7-46fe-9f21-60ce0dd8d76a","amount":4.75,"currency":"BAT","destination":"60ec69b1-f02c-467e-9247-8c174c49eb95","status":"Completed","timestampms":1635277391390}
[24776:259:1029/154447.948191:VERBOSE9:logging_util.cc(137)] 
[ RESPONSE HEADERS ]
> Url: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/20afec3a-acd7-46fe-9f21-60ce0dd8d76a
[24776:259:1029/154447.948248:VERBOSE1:get_transaction_gemini.cc(88)] Transfer Status: Completed
[24776:259:1029/154447.949338:INFO:gemini_transfer.cc(104)] Number of active retry timers: 0
[24776:259:1029/154447.949417:VERBOSE1:gemini.cc(212)] Gemini transfer fee timer set for 33 s
[24776:259:1029/154520.955293:INFO:post_transaction_gemini.cc(103)] Initiating gemini transaction to: 60edbc1b-eaa7-4aa0-afb8-a87a89634c55for 0.25
[24776:259:1029/154520.955408:VERBOSE5:ledger_impl.cc(119)] 
[ REQUEST ]
> URL: https://api.qa6.aurora7.net/v1/payments/pay
> Method: POST
> Content Type: application/json; charset=utf-8
[24776:259:1029/154521.155527:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api.qa6.aurora7.net/v1/payments/pay
> Result: Success
> HTTP Code: 200
> Body: {"result":"OK","tx_ref":"b5ecc394-0ea4-477a-845c-bc12156f6e58","amount":0.25,"currency":"BAT","destination":"60edbc1b-eaa7-4aa0-afb8-a87a89634c55","status":"Pending"}
[24776:259:1029/154521.155634:VERBOSE9:logging_util.cc(137)] 
[ RESPONSE HEADERS ]
> Url: https://api.qa6.aurora7.net/v1/payments/pay
[24776:259:1029/154521.156761:INFO:post_transaction_gemini.cc(116)] Gemini transaction successful
[24776:259:1029/154521.156844:VERBOSE1:post_transaction_gemini.cc(129)] Transfer Pending
[24776:259:1029/154521.156903:VERBOSE1:gemini_transfer.cc(75)] Will fetch transaction status after 3 minutes
[24776:259:1029/154821.157523:VERBOSE1:gemini_transfer.cc(86)] Fetching transaction status 1 time
[24776:259:1029/154821.158088:VERBOSE5:ledger_impl.cc(119)] 
[ REQUEST ]
> URL: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/b5ecc394-0ea4-477a-845c-bc12156f6e58
> Method: GET
> Content Type: application/json; charset=utf-8
[24776:259:1029/154821.320258:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/b5ecc394-0ea4-477a-845c-bc12156f6e58
> Result: Success
> HTTP Code: 200
> Body: {"tx_ref":"b5ecc394-0ea4-477a-845c-bc12156f6e58","amount":0.25,"currency":"BAT","destination":"60edbc1b-eaa7-4aa0-afb8-a87a89634c55","status":"Pending"}
[24776:259:1029/154821.320330:VERBOSE9:logging_util.cc(137)] 
[ RESPONSE HEADERS ]
> Url: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/b5ecc394-0ea4-477a-845c-bc12156f6e58
[24776:259:1029/154821.320370:VERBOSE1:get_transaction_gemini.cc(88)] Transfer Status: Pending
[24776:259:1029/154821.321123:INFO:gemini_transfer.cc(104)] Number of active retry timers: 0
[24776:259:1029/154821.321178:VERBOSE1:gemini_transfer.cc(75)] Will fetch transaction status after 6 minutes
[24776:259:1029/155421.324687:VERBOSE1:gemini_transfer.cc(86)] Fetching transaction status 2 time
[24776:259:1029/155421.325851:VERBOSE5:ledger_impl.cc(119)] 
[ REQUEST ]
> URL: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/b5ecc394-0ea4-477a-845c-bc12156f6e58
> Method: GET
> Content Type: application/json; charset=utf-8
[24776:259:1029/155421.501051:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/b5ecc394-0ea4-477a-845c-bc12156f6e58
> Result: Success
> HTTP Code: 200
> Body: {"tx_ref":"b5ecc394-0ea4-477a-845c-bc12156f6e58","amount":0.25,"currency":"BAT","destination":"60edbc1b-eaa7-4aa0-afb8-a87a89634c55","status":"Completed","timestampms":1635277991742}
[24776:259:1029/155421.501158:VERBOSE9:logging_util.cc(137)] 
[ RESPONSE HEADERS ]
> Url: https://api.qa6.aurora7.net/v1/payment/60df8caa-795b-4eef-a8bf-585e3799d454/b5ecc394-0ea4-477a-845c-bc12156f6e58
[24776:259:1029/155421.501216:VERBOSE1:get_transaction_gemini.cc(88)] Transfer Status: Completed

Confirmed the tip and fee were sent successfully

Example Example Example
1 2 3
Brave | 1.32.84 Chromium: 95.0.4638.54 (Official Build) beta (x86_64)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | macOS Version 11.6 (Build 20G165)
Gemini --> Uphold wallet change - PASSED

Verified test plan from brave/brave-core#10324 (comment)

Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:

Example Example
Screen Shot 2021-10-28 at 4 36 08 PM Screen Shot 2021-10-28 at 4 36 20 PM

Confirmed able to disconnect from Uphold and connect Gemini account per step 4:
Screen Shot 2021-10-28 at 4 38 45 PM

Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel:
Screen Shot 2021-10-31 at 4 39 57 PM

I checked the logs and saw that the tip was now being initiated.

Step 6 logs
[41450:259:1031/163930.123505:VERBOSE1:contribution.cc(362)] Creating contribution for wallet type uphold (amount: 1, type: ONE_TIME_TIP)
....
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/aec5f5cb-362f-4aaa-a772-0d6834b3da18/transactions
> Method: POST
> Content: {"denomination":{"amount":"0.950000","currency":"BAT"},"destination":"987cc5c7-e639-475f-af27-a54e6b91a25e","message":""}
> Content Type: application/json; charset=utf-8
[41450:259:1031/163930.751697:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/aec5f5cb-362f-4aaa-a772-0d6834b3da18/transactions
> Result: Success
> HTTP Code: 202
...........
[41450:259:1031/163931.037052:VERBOSE1:uphold.cc(244)] Uphold transfer fee timer set for 61 s
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/aec5f5cb-362f-4aaa-a772-0d6834b3da18/transactions
> Method: POST
> Content: {"denomination":{"amount":"0.050000","currency":"BAT"},"destination":"1b2b466f-5c15-49bf-995e-c91777d3da93","message":"5% transaction fee collected by Brave Software International"}
> Content Type: application/json; charset=utf-8
[41450:259:1031/164032.246217:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/aec5f5cb-362f-4aaa-a772-0d6834b3da18/transactions
> Result: Success
> HTTP Code: 202

Confirmed the tip and fee were sent successfully

Example Example Example
Screen Shot 2021-10-31 at 4 45 24 PM Screen Shot 2021-10-31 at 4 45 29 PM Screen Shot 2021-10-31 at 4 45 37 PM

Verification passed on

Brave 1.32.90 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#10324

Verified wallet with uphold ![image](https://user-images.githubusercontent.com/34715963/141194774-d9f566eb-8abb-46cd-b263-9f07a5a468c8.png)

Made the tip to gemini verified creator lands in pending contributions
image

Verified wallet with gemini
image

Verified after 3 days the tip was removed from pending contributions
image

Verified database was migrated
image

Verified there's no processor column in the pending_contribution table
image

@LaurenWags LaurenWags added QA/Blocked QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Blocked labels Oct 27, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 29, 2021
@stephendonner
Copy link

stephendonner commented Oct 31, 2021

Verified PASSED using

Brave 1.32.86 Chromium: 95.0.4638.54 (Official Build) beta (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Windows 10 Version 20H2 (Build 19042.1288)
Clean Profile - PASSED

Per brave/brave-core#10324 (comment), confirmed database migration (v1 -> v33) is successful.
Also confirmed there's no processor column in the pending_contribution table.

Example Example
clean-profile-db upgrade-04
Upgrade Profile - PASSED

Installed 1.31.87 and enabled Rewards.
Confirmed DB version is 32 and there is a processor column in the pending_contribution table.

Example Example
upgrade-01 upgrade-02

Upgraded to 1.32.81 by renaming the profile.
Per brave/brave-core#10324 (comment), confirmed database migration (v32 -> v33) is successful. (note, DB migration in logs shows 33->33. Discussed this with Szilard and he confirmed that previous migrations also showed this way in the logs)
Also confirmed there's no processor column in the pending_contribution table.

Example Example
upgrade-03 upgrade-04
Uphold --> Gemini wallet change - PASSED

Verified test plan from brave/brave-core#10324 (comment)

Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:

Example Example
2 3

Confirmed able to disconnect from Uphold and connect Gemini account per step 4:
6

Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel:

I checked the logs and saw that the tip was now being initiated.

Step 6 logs
[1308:13996:1101/225116.131:VERBOSE1:contribution.cc(362)] Creating contribution for wallet type gemini (amount: 5, type: ONE_TIME_TIP)
[1308:13996:1101/225116.137:ERROR:os_crypt_win.cc(93)] Failed to decrypt: The parameter is incorrect. (0x57)
[1308:13996:1101/225116.137:ERROR:binance_service.cc(308)] Could not decrypt and save Binance token info.
[1308:13996:1101/225116.138:VERBOSE1:contribution.cc(91)] Queue timer set for 1 s
[1308:13996:1101/225116.138:VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
[1308:13996:1101/225116.140:INFO:post_transaction_gemini.cc(103)] Initiating gemini transaction to: 60ec69b1-f02c-467e-9247-8c174c49eb95for 4.75
[1308:13996:1101/225116.140:VERBOSE5:ledger_impl.cc(119)]
[ REQUEST ]
> URL: https://api.qa6.aurora7.net/v1/payments/pay
> Method: POST
> Content Type: application/json; charset=utf-8
[1308:13996:1101/225116.204:ERROR:os_crypt_win.cc(93)] Failed to decrypt: The parameter is incorrect. (0x57)
[1308:13996:1101/225116.204:ERROR:gemini_service.cc(420)] Could not decrypt and save Gemini access token
[1308:13996:1101/225116.207:INFO:CONSOLE(3093)] "setting today viewport observer, should only happen once", source: chrome://newtab/brave_new_tab.bundle.js (3093)
[1308:13996:1101/225116.243:WARNING:CONSOLE(1)] "Could not find style data in module named br-shared-style", source: chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js (1)
[1308:13996:1101/225116.273:VERBOSE5:ledger_impl.cc(119)]
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&paymentId=97dab9fc-21bd-4468-a91d-b52ba6218b3b&platform=windows
> Method: GET
[1308:13996:1101/225116.274:VERBOSE1:uphold.cc(114)] Uphold wallet is not VERIFIED.
[1308:13996:1101/225116.274:VERBOSE5:ledger_impl.cc(119)]
[ REQUEST ]
> URL: https://api.qa6.aurora7.net/v1/balances
> Method: POST
[1308:13996:1101/225116.287:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://api.qa6.aurora7.net/v1/payments/pay
> Result: Success
> HTTP Code: 200
> Body: {"result":"OK","tx_ref":"ff681393-e33e-471b-88af-3393aefeed08","amount":4.75,"currency":"BAT","destination":"60ec69b1-f02c-467e-9247-8c174c49eb95","status":"Pending"}
[1308:13996:1101/225116.288:INFO:post_transaction_gemini.cc(116)] Gemini transaction successful
[1308:13996:1101/225116.288:VERBOSE1:post_transaction_gemini.cc(129)] Transfer Pending
[1308:13996:1101/225116.288:VERBOSE1:gemini_transfer.cc(75)] Will fetch transaction status after 3 minutes

Confirmed the tip and fee were sent successfully

Example Example
gemini-06 gemini-07
Gemini --> Uphold wallet change - PASSED

Verified test plan from brave/brave-core#10324 (comment)

Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:

Example Example
gemini-01 gemini-02

Confirmed able to disconnect from Gemini and connect Uphold account per step 4:

gemini-03

Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel:

gemini-05

I checked the logs and saw that the tip was now being initiated.

Step 6 logs
[4300:2712:1103/141538.082:VERBOSE1:uphold.cc(244)] Uphold transfer fee timer set for 96 s
[4300:2712:1103/141538.099:VERBOSE5:ledger_impl.cc(119)]
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/373ab929-0607-4fbc-b83b-80fd78e06932
> Method: GET
[4300:2712:1103/141538.248:VERBOSE6:logging_util.cc(136)]
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/373ab929-0607-4fbc-b83b-80fd78e06932
> Result: Success
> HTTP Code: 200
-----
[4300:2712:1103/141537.228:VERBOSE1:contribution.cc(362)] Creating contribution for wallet type uphold (amount: 5, type: ONE_TIME_TIP)
[4300:2712:1103/141537.235:VERBOSE1:contribution.cc(91)] Queue timer set for 18 s
[4300:2712:1103/141537.236:VERBOSE5:ledger_impl.cc(119)]
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/373ab929-0607-4fbc-b83b-80fd78e06932/transactions
> Method: POST
> Content: {"denomination":{"amount":"4.750000","currency":"BAT"},"destination":"987cc5c7-e639-475f-af27-a54e6b91a25e","message":""}
> Content Type: application/json; charset=utf-8

Confirmed the tip and fee were sent successfully

Example Example
gemini-07 gemini-06

@stephendonner stephendonner added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 31, 2021
@stephendonner
Copy link

stephendonner commented Nov 10, 2021

Verified in-progress using

Clean Profile - PASSED

Per brave/brave-core#10324 (comment), confirmed database migration (v1 -> v33) is successful.
Also confirmed there's no processor column in the pending_contribution table.

Example Example
Screen Shot 2021-11-10 at 11 16 48 AM Screen Shot 2021-11-10 at 11 23 43 AM
Upgrade Profile - PASSED

Installed 1.31.87 and enabled Rewards.
Confirmed DB version is 32 and there is a processor column in the pending_contribution table.

Example Example
Screen Shot 2021-11-10 at 11 28 39 AM Screen Shot 2021-11-10 at 11 29 48 AM

Upgraded to 1.32.81 by renaming the profile.
Per brave/brave-core#10324 (comment), confirmed database migration (v32 -> v33) is successful. (note, DB migration in logs shows 33->33. Discussed this with Szilard and he confirmed that previous migrations also showed this way in the logs)
Also confirmed there's no processor column in the pending_contribution table.

Example Example
Screen Shot 2021-11-10 at 11 31 53 AM Screen Shot 2021-11-10 at 11 32 33 AM
Uphold --> Gemini wallet change - PASSED

Verified test plan from brave/brave-core#10324 (comment)

Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:

Example Example
Screen Shot 2021-11-10 at 11 42 40 AM Screen Shot 2021-11-10 at 11 42 52 AM

Confirmed able to disconnect from Uphold and connect Gemini account per step 4:
SCREENSHOT

Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel:

I checked the logs and saw that the tip was now being initiated.

Step 6 logs
.

Confirmed the tip and fee were sent successfully

Example Example
Gemini --> Uphold wallet change - PASSED

Verified test plan from brave/brave-core#10324 (comment)

Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:

Example Example

Confirmed able to disconnect from Gemini and connect Uphold account per step 4:

SCREENSHOT

Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel:

SCREENSHOT

I checked the logs and saw that the tip was now being initiated.

Step 6 logs
.

Confirmed the tip and fee were sent successfully

Example Example

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 10, 2021
@stephendonner stephendonner removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment