Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr93 followup] Remove --disable-gpu-sandbox flag from browser tests on Windows. #17568

Closed
mkarolin opened this issue Aug 19, 2021 · 1 comment · Fixed by brave/brave-core#10664
Closed

[cr93 followup] Remove --disable-gpu-sandbox flag from browser tests on Windows. #17568

mkarolin opened this issue Aug 19, 2021 · 1 comment · Fixed by brave/brave-core#10664
Labels
dev-concern OS/Windows QA/No release-notes/exclude
Milestone
1.34.x - Release

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Aug 19, 2021 •
edited
Loading

In cr93 bump this flag was added because a large number of browser tests was failing on Windows CI, while working fine locally.

brave/brave-core@3b97a2b - commit that added the flag.

We need to figure out what's causing CI failures and remove the flag.
@mkarolin mkarolin changed the title Remove --disable-gpu-sandbox flag from browser tests on Windows. [cr93 followup] Remove --disable-gpu-sandbox flag from browser tests on Windows. Aug 19, 2021
@mkarolin
Copy link
Contributor Author

Ran upstream browser tests on our Win CI and they fail with the same errors as our tests.

@mkarolin mkarolin mentioned this issue Dec 3, 2021
Merged
24 tasks
@bridiver bridiver added this to the 1.35.x - Nightly milestone Dec 8, 2021
@mkarolin mkarolin mentioned this issue Dec 14, 2021
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern OS/Windows QA/No release-notes/exclude
Projects
None yet
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 96 to Chromium 97 brave/brave-core
3 participants
@bridiver @kjozwiak @mkarolin