Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Extension increases page load times by ×10 #17538

Closed
da2x opened this issue Aug 18, 2021 · 8 comments
Closed

Brave Extension increases page load times by ×10 #17538

da2x opened this issue Aug 18, 2021 · 8 comments
Labels
closed/duplicate Issue has already been reported features/shields/cosmetic-filtering needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop perf

Comments

@da2x
Copy link

da2x commented Aug 18, 2021

Steps to Reproduce

  1. Visit a very simple HTML page like https://example.com
  2. Open Developer Tools: Performance
  3. Click record page load time.
  4. Focus in on the page load portion and inspect what’s slowing down the page load.

(Compare to Edge or Chrome with no extensions.)

Actual result:

content_cosmetic.bundle.js (a script inserted by the bundled Brave Extension) increases the page load time by ×10.

Even for simple pages, page loads go from 30–50 ms to 500–700 ms. (Times excluding networking overhead.)

For more complex pages served from a local file (no network overhead), the Lighthouse performance score drops from 98 to low 60s.

Expected result:

No compromises on performance. (Or, at least only tiny ones.)

Reproduces how often:

Every time.

Brave version (brave://version info)

1.28.105 Chromium: 92.0.4515.13

Version/Channel Information:

stable

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?

no.

  • Does the issue resolve itself when disabling Brave Rewards?

no.

  • Is the issue reproducible on the latest version of Chrome?

no, it’s Brave specific.

@bsclifton
Copy link
Member

cc: @antonok-edm

@antonok-edm
Copy link
Collaborator

@da2x I'm not able to reproduce your issue. I do see some overhead, but certainly not 10x.
2021-08-26-113823_798x569_scrot

For comparison, I get 74ms for Scripting when running with Shields disabled.

If you're seeing 500-700ms then something definitely sounds wrong, but I'll need more information to look into it further.

@antonok-edm antonok-edm added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Aug 26, 2021
@da2x
Copy link
Author

da2x commented Aug 27, 2021

I get the same result on my much faster gaming desktop computer, but I get 500–700 ms on my Lenovo laptop from 2018. I can reproduce it on my desktop by throttling the processor. Intel i5 7200U with relatively slow 1GHz RAM.

@Tonev
Copy link
Contributor

Tonev commented Sep 7, 2021

@bsclifton @antonok-edm

Related to #17906?

@antonok-edm
Copy link
Collaborator

@Tonev possibly. It would also be good to check if it's affected at all by brave/brave-core#9995

@atuchin-m
Copy link
Contributor

atuchin-m commented Sep 8, 2021

To resolve this the following issues should be done:

@iefremov
Copy link
Contributor

@da2x we significantly optimized Brave Extension in Nightly, would be great if you could test that.

@iefremov
Copy link
Contributor

Pls reopen if this happens again

@iefremov iefremov added the closed/duplicate Issue has already been reported label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported features/shields/cosmetic-filtering needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop perf
Projects
None yet
Development

No branches or pull requests

7 participants