Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to set the timeout to transition out the tipping feedback screen #1742

Closed
jenn-rhim opened this issue Oct 19, 2018 · 2 comments · Fixed by brave/brave-core#801
Closed

Comments

@jenn-rhim
Copy link

jenn-rhim commented Oct 19, 2018

Description

The 'Thank you' screen' after sending tip button is clicked needs to be a transient feedback screen that shouldn't require the user's click to close. The initial design intent was to add an animation for the transitioning it out.

- Propose to set a timeout on this screen at 3 sec, ease out.

screen shot 2018-10-19 at 12 11 58 pm

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@petemill
Copy link
Member

@NejcZdovc I'm going to un-assign from myself for now since this can be achieved in the JS for the donate page. Whoever gets to this can call the dialog close JS after a timeout.

@petemill petemill removed their assignment Oct 23, 2018
@NejcZdovc NejcZdovc self-assigned this Oct 24, 2018
@NejcZdovc NejcZdovc assigned jasonrsadler and unassigned NejcZdovc Oct 29, 2018
@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 30, 2018
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 30, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.59.x - Nightly, 0.58.x - Dev Nov 5, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Dec 11, 2018

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

Used STR from brave/brave-core#801

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux
  • Verified banner is closed after 3 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants