Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to dislike ads from advertisers by clicking the ads history thumbs down button #17319

Closed
tmancey opened this issue Aug 3, 2021 · 1 comment · Fixed by brave/brave-core#10323

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 3, 2021

No description provided.

@btlechowski
Copy link

Verification passed on

Brave 1.35.85 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#10323

Verified after dislike, client.json contains

{"adPreferences":{"filtered_advertisers":[{"id":"ecbcc833-8b1d-4867-98f7-ad2341396ce8"}]

Verified ad was not shown due to advertiser being blocked

[12036:12036:0117/000616.066296:VERBOSE2:exclusion_rules_base.cc(123)] advertiserId ecbcc833-8b1d-4867-98f7-ad2341396ce8 excluded due to being disliked
[12036:12036:0117/000616.066364:VERBOSE1:seen_advertisers.h(30)] All ad_notification advertisers have been shown, so round robin
[12036:12036:0117/000616.066420:VERBOSE1:client.cc(446)] Resetting seen ad_notification advertisers
[12036:12036:0117/000616.066738:VERBOSE1:seen_ads.h(30)] All ad_notification ads have been shown, so round robin
[12036:12036:0117/000616.066801:VERBOSE1:client.cc(410)] Resetting seen ad_notifications
[12036:12036:0117/000616.066982:VERBOSE1:eligible_ad_notifications_v1.cc(150)] No eligible ads for untargeted segment
[12036:12036:0117/000616.067120:VERBOSE1:ad_notification_serving.cc(136)] Ad notification not served: No eligible ads found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
2 participants