Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #16940 - Brave branded bookmarks subfolder images are not shown clearly in Private tabs #17214

Closed
GeetaSarvadnya opened this issue Jul 28, 2021 · 2 comments · Fixed by brave/brave-core#10037

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 28, 2021

Description

Follow up of #16940 - Brave branded bookmarks subfolder images are not shown clearly in Private tabs

Test plan / Steps to Reproduce

  1. Clean profile 1.28.92
  2. Import bookmarks folder or create a new bookmarks folder in the bookmarks bar
  3. Open Private tab/Tor private tab
  4. Brave branded bookmarks subfolder images are not shown clearly in Private tabs

Actual result:

image

Expected result:

Brave branded bookmarks subfolder images should be shown clearly in Private tabs

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.28.92 Chromium: 92.0.4515.107 (Official Build) beta (64-bit)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS Windows 10 OS Version 2004 (Build 19041.1110)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @simonhong @rebron @karenkliu

@GeetaSarvadnya GeetaSarvadnya changed the title Follow up of #16940 - Brave branded bookmarks bar folder images are not shown clearly in Private tabs Follow up of #16940 - Brave branded bookmarks bar subfolder images are not shown clearly in Private tabs Jul 28, 2021
@simonhong simonhong self-assigned this Jul 28, 2021
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jul 28, 2021
@GeetaSarvadnya GeetaSarvadnya changed the title Follow up of #16940 - Brave branded bookmarks bar subfolder images are not shown clearly in Private tabs Follow up of #16940 - Brave branded bookmarks subfolder images are not shown clearly in Private tabs Jul 29, 2021
@bsclifton bsclifton self-assigned this Sep 10, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Sep 10, 2021
- Windows icons are back to yellow
- macOS and Linux use a gray colored icon (Linux has slightly different
  dimensions)

Having a proper icon solves the visibility issue for sub-folders on
private window.

Fixes brave/brave-browser#17463
Fixes brave/brave-browser#17214
@bsclifton bsclifton added this to the 1.31.x - Nightly milestone Sep 11, 2021
@kjozwiak
Copy link
Member

Going to release-notes/exclude as #17463 basically covers this change/fix as well.

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Sep 13, 2021

Verification passed on


Brave | 1.29.80 Chromium: 93.0.4577.63 (Official Build) (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Clean profile

Regular window Light theme Regular window Dark theme
image image
Private window Light theme Private window Dark theme
image image
Tor window Light theme Tor window Dark theme
image image

Upgrade profile

Install 1.29.79 have some bookmarks in the bookmarks bar and upgrade the profile to 1.29.80 and confirmed that the bookmarks folder icons are reverted back to Yellow

1.29.79 1.29.80
image image

Verification PASSED on macOS 11.5.2 x64 using the following build:

Brave | 1.29.80 Chromium: 93.0.4577.63 (Official Build) (x86_64)
--- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | macOS Version 11.5.2 (Build 20G95)

Clean profile

Regular window Light theme Regular window Dark theme
Screen Shot 2021-09-13 at 12 40 36 PM Screen Shot 2021-09-13 at 12 30 43 PM
Private window Light theme Private window Dark theme
Screen Shot 2021-09-13 at 12 31 44 PM Screen Shot 2021-09-13 at 12 32 18 PM
Tor window Light theme Tor window Dark theme
Screen Shot 2021-09-13 at 12 32 51 PM Screen Shot 2021-09-13 at 12 33 16 PM

Upgrade profile

Install 1.29.79 have some bookmarks in the bookmarks bar and upgrade the profile to 1.29.80 and confirmed that the bookmarks folder icons are reverted back to Yellow as per the following:

1.29.79 1.29.80
Screen Shot 2021-09-13 at 12 30 16 PM Screen Shot 2021-09-13 at 12 30 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants