Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long Ads titles need better styling in brave://rewards' Ads History #17179

Closed
stephendonner opened this issue Jul 26, 2021 · 1 comment
Closed

Long Ads titles need better styling in brave://rewards' Ads History #17179

stephendonner opened this issue Jul 26, 2021 · 1 comment
Labels
bug feature/rewards OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon".

Comments

@stephendonner
Copy link

Description

Long Ads titles need better styling in brave://rewards' Ads History

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. open a new-tab page
  4. click to Start using Rewards
  5. scroll down and click Show Brave News
  6. view/click on a inline-content ad
  7. open a new tab page with a sponsored image
  8. open brave://rewards
  9. look at the layout of the Make your gear more... ad entry

Actual result:

Screen Shot 2021-07-26 at 10 58 18 AM

Expected result:

Either better line wrapping/padding, or the size (length) of the box borders could use increasing, to match the longest strings possible via Ads.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.29.27 Chromium: 92.0.4515.107 (Official Build) nightly (x86_64)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS macOS Version 11.5 (Build 20G71)

/cc @rebron (credit for finding)
@stephendonner stephendonner added bug polish Nice to have — usually related to front-end/visual tasks feature/rewards OS/Desktop labels Jul 26, 2021
@zenparsing zenparsing added the priority/P4 Planned work. We expect to get to it "soon". label Jul 28, 2021
@Miyayes Miyayes mentioned this issue Mar 28, 2023
Closed
@Miyayes
Copy link
Collaborator

Miyayes commented Apr 20, 2023

Will close in favor of #29365

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature/rewards OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stephendonner @zenparsing @Miyayes