Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Start video call" button in card should link to talk.brave.com/widget #17146

Closed
stephendonner opened this issue Jul 24, 2021 · 5 comments · Fixed by brave/brave-core#9581
Closed

Comments

@stephendonner
Copy link

stephendonner commented Jul 24, 2021

Description

Start video call button in card should link to talk.brave.com/widget

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load a new-tab page
  4. click on Edit cards
  5. add the Brave Together (to be renamed to Brave Talk) card
  6. open the Network panel in Developer Tools
  7. click on the Start video call button
  8. look at the URLs/redirects

Actual result:

button URL
Screen Shot 2021-07-24 at 11 34 20 AM Screen Shot 2021-07-24 at 11 35 07 AM

Expected result:

Should go to talk.brave.com/widget without any loads to/redirects from together.brave.com

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.29.20 Chromium: 92.0.4515.107 (Official Build) nightly (x86_64)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS macOS Version 12.0 (Build 21A5284e)

cc @mattmcalister @rebron @bsclifton

@stephendonner stephendonner changed the title "Start video call button" in card should link to talk.brave.com/widget "Start video call" button in card should link to talk.brave.com/widget Jul 24, 2021
@stephendonner stephendonner self-assigned this Jul 24, 2021
bsclifton pushed a commit to brave/brave-core that referenced this issue Jul 28, 2021
@bsclifton bsclifton added this to the 1.29.x - Nightly milestone Jul 29, 2021
@stephendonner
Copy link
Author

@bsclifton think we can get an uplift going for 1.28.x? /cc @mattmcalister

@bsclifton
Copy link
Member

@stephendonner done - brave/brave-core#9608

@kjozwiak
Copy link
Member

kjozwiak commented Aug 9, 2021

Adding QA/Blocked until we get Brave Talk enabled on main (staging) via Griffin. After it's enabled on staging, QA will be able to run through the above verification. Once we get closer to Brave Talk release date, we'll push the same change into production.

@kjozwiak
Copy link
Member

kjozwiak commented Aug 9, 2021

Removing QA/Blocked as brave/brave-variations#93 was merged into main (Griffin staging).

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 10, 2021

Verification passed on

Brave | 1.28.105 Chromium: 92.0.4515.131 (Official Build) (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1110)

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment