Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run bat-native-ledger in a utility process #1708

Closed
bridiver opened this issue Oct 18, 2018 · 2 comments · Fixed by brave/brave-core#989
Closed

Run bat-native-ledger in a utility process #1708

bridiver opened this issue Oct 18, 2018 · 2 comments · Fixed by brave/brave-core#989

Comments

@bridiver
Copy link
Contributor

bridiver commented Oct 18, 2018

We want to isolate the browser process from perf and potential crash issues so we will run bat-native-ledger in a utility process. RewardsService will manage that utility process and communicate to it using mojo bindings. Webui and other code in brave-core and bat-native-ledger will not be affected except for the changes in #1709

@bbondy bbondy added this to the 1.x Backlog milestone Oct 19, 2018
@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. dev-concern labels Oct 19, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.56.x - Beta Oct 22, 2018
@yrliou yrliou assigned yrliou and unassigned bridiver Oct 24, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.56.x - Beta, 0.57.x - Dev Oct 25, 2018
@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 30, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Dec 31, 2018
@yrliou yrliou added the QA/Yes label Dec 31, 2018
@yrliou
Copy link
Member

yrliou commented Dec 31, 2018

Added QA/Yes label, this would need to test the whole rewards flow.

@LaurenWags
Copy link
Member

LaurenWags commented Feb 20, 2019

Verified passed with

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X
  • Verified general Rewards regression and flow using several builds, but most recently with the one above.

Verification passed on

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 7

Verified general Rewards regression
Verified update flow

Verification passed on

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux

Verified rewards flow general and upgrade path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants