Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Unable to perform contribution #17034

Closed
srirambv opened this issue Jul 19, 2021 · 6 comments · Fixed by brave/brave-core#16232
Closed

[Android] Unable to perform contribution #17034

srirambv opened this issue Jul 19, 2021 · 6 comments · Fixed by brave/brave-core#16232
Assignees
Labels
feature/rewards intermittent-issue OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Unable to perform contribution

Steps to reproduce

  1. Enable rewards
  2. Try performing contribution
  3. Doesn't go through

Actual result

2021-08-14 05:03:58.102 12243-12243/? V/chromium: [VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id b25585f5-44cd-44a9-b096-f745602213ab, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and view
2021-08-14 05:03:58.105 12243-12243/? V/chromium: [VERBOSE1:confirmations.cc(271)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 1 unblinded payment tokens
2021-08-14 05:03:58.107 12243-12243/? V/chromium: [VERBOSE1:refill_unblinded_tokens.cc(66)] No need to refill unblinded tokens as we already have 49 unblinded tokens which is above the minimum threshold of 20
2021-08-14 05:03:58.525 12243-12243/? V/chromium: [VERBOSE1:contribution.cc(744)] Retrying contribution (a208311b-91e2-407f-a6a1-49aba3dfb89c) on step STEP_PREPARE
2021-08-14 05:03:58.526 12243-12243/? V/chromium: [VERBOSE1:contribution_unblinded.cc(185)] Token list is empty
2021-08-14 05:03:58.533 12243-12243/? I/chromium: [INFO:credentials_promotion.cc(455)] Token list empty
2021-08-14 05:03:58.536 12243-12243/? I/chromium: [INFO:contribution_unblinded.cc(503)] Tokens were not processed correctly

Expected result

Contribution should go through

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv srirambv added release/blocking feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. OS/Android Fixes related to Android browser functionality labels Jul 19, 2021
@srirambv srirambv added this to the 1.27.x - Release milestone Jul 19, 2021
@srirambv srirambv added intermittent-issue priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. release/blocking labels Jul 23, 2021
@srirambv
Copy link
Contributor Author

This seems to be an intermittent issue on the current release build as well. @GeetaSarvadnya was also able to reproduce the issue with and without one-time/recurring tips. Moving the issue out of the milestone as this will require some investigation before landing a fix for it

cc: @kjozwiak @deeppandya @zenparsing @tmancey

@srirambv srirambv removed this from the 1.27.x - Release milestone Jul 23, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Aug 4, 2021

@anthonypkeane @bsclifton we should probably get someone to take a look at this and see if they can reproduce and see why AC isn't as reliable on Android and fails from time to time.

@deeppandya
Copy link

@kjozwiak I think we would need someone to look at it from backend side. I looked into the issue but we haven't updated rewards in Android side at all so it may be something from backend. I would be happy to jump on it.
CC @zenparsing

@zenparsing zenparsing self-assigned this Aug 4, 2021
@srirambv
Copy link
Contributor Author

Ran into this while testing 1.29.80 build

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 14, 2021

Ran into this issue while upgrading 1.29.79 to 1.29.80 on Android Tab ( issue occurred in 1.29.79)

@Miyayes Miyayes added the needs-investigation A bug not 100% confirmed/fixed label Apr 26, 2022
@Miyayes Miyayes changed the title Unable to perform contribution [Android] Unable to perform contribution May 25, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 6, 2022
@kjozwiak kjozwiak added release-notes/exclude and removed needs-investigation A bug not 100% confirmed/fixed labels Dec 15, 2022
@stephendonner
Copy link

stephendonner commented Jan 31, 2023

Verification PASSED using Brave 1.48.149, Chromium 109.0.5414.119 on a Google Pixel XL (arm64) running Android 9

Unverified - PASSED

  1. installed 1.47.161
  2. tapped through onboarding
  3. set Rewards to staging via QA Preferences menu
  4. relaunched
  5. tapped on the BAT icon in the URL bar
  6. tapped Start using Brave Rewards
  7. selected United States and tapped Continue
  8. tapped SKIP
  9. tapped DONE
  10. tapped on the BAT icon again
  11. confirmed and accepted the free token grant
  12. installed 1.48.149 atop 1.47.161 (both are beta-channel builds)
  13. loaded laurenwags.github.io
  14. set monthly tip to 1.00
  15. shut down Brave
  16. fast-forwarded system clock to next-month contribute day +1
  17. relaunched Brave
  18. waited
  19. confirmed monthly contribution was processed
example example example example example example
Screenshot_20230131-153533 Screenshot_20230131-153601 Screenshot_20230131-153609 Screenshot_20230304-153703 Screenshot_20230304-153728 Screenshot_20230304-153738

Uphold - PASSED

  1. installed 1.47.161
  2. tapped through onboarding
  3. set Rewards to staging via QA Preferences menu
  4. relaunched
  5. tapped on the BAT icon in the URL bar
  6. tapped Start using Brave Rewards
  7. selected United States and tapped Continue
  8. tapped SKIP
  9. tapped DONE
  10. logged tapped Connect
  11. tapped Uphold
  12. logged into Uphold staging
  13. confirmed and accepted the free token grant
  14. installed 1.48.149 atop 1.47.161 (both are beta-channel builds)
  15. loaded laurenwags.github.io
  16. set monthly tip to 1.00
  17. shut down Brave
  18. fast-forwarded system clock to next-month contribute day +1
  19. relaunched Brave
  20. waited
  21. confirmed monthly contribution was processed
(missing initial-balance screenshot) example example example example
missing, sorry! Screenshot_20230131-144824 Screenshot_20230131-144834 Screenshot_20230304-144919 Screenshot_20230304-144945

@srirambv of course, should you encounter this again, please do file a new issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards intermittent-issue OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants