Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connected peers count should be 0 when node is stopped #16804

Closed
stephendonner opened this issue Jul 7, 2021 · 1 comment · Fixed by brave/brave-core#9369
Closed

Connected peers count should be 0 when node is stopped #16804

stephendonner opened this issue Jul 7, 2021 · 1 comment · Fixed by brave/brave-core#9369
Assignees
@spylogsster
Labels
feature/web3/ipfs OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-macOS QA/Yes release-notes/include
Milestone
1.28.x - Release

Comments

@stephendonner
Copy link

stephendonner commented Jul 7, 2021 •
edited
Loading

Description

Connected peers count should be 0 when node is stopped

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load brave://ipfs
  4. click Install and start
  5. now click Stop
  6. look at the Connected peers: count

Actual result:

The Connected peers: count is non-zero

Screen Shot 2021-07-06 at 6 50 44 PM

Expected result:

When stopping the node, Connected peers: should reset to 0.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)

/cc @autonome
@stephendonner stephendonner added the polish Nice to have — usually related to front-end/visual tasks label Jul 7, 2021
@spylogsster spylogsster self-assigned this Jul 8, 2021
@spylogsster spylogsster mentioned this issue Jul 8, 2021
Merged
24 tasks
@spylogsster spylogsster added this to the 1.28.x - Nightly milestone Jul 14, 2021
@stephendonner
Copy link
Author

Verified FIXED using the inline testplan with

Brave 1.28.82 Chromium: 92.0.4515.93 (Official Build) nightly (x86_64)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS macOS Version 11.4 (Build 20F71)
  1. new profile
  2. launch Brave
  3. load brave://ipfs
  4. click Install and start
  5. now click Stop
  6. look at the Connected peers: count

Confirmed the Connected peers: count resets to 0 on Stop

ipfs-stop-count

@LaurenWags LaurenWags mentioned this issue Aug 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/ipfs OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.28.x - Release
Development

Successfully merging a pull request may close this issue.

Reset connected peers when daemon is not launched brave/brave-core
2 participants
@stephendonner @spylogsster