Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipns and ipfs URLs should not redirect/load over a Gateway in Private and Guest windows #16737

Closed
stephendonner opened this issue Jul 1, 2021 · 5 comments · Fixed by brave/brave-core#9355

Comments

@stephendonner
Copy link

Description

ipns:// and ipfs:// URLs should not redirect/load over a Gateway in Private and Guest windows

See #12978 for more details - the below testplan is from there.

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. set Method to resolve IPFS resources to Gateway in brave://settings/ipfs
  4. do either/both a Private Window / Guest Window
  5. load ipns://brantly.eth or ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR

Actual result:

Both URLs resolve and load in Private and Guest windows (but not in Private Window with Tor).

example example
Screen Shot 2021-07-01 at 10 16 33 AM Screen Shot 2021-07-01 at 10 17 42 AM

Expected result:

Per #12978 they shouldn't load in Private or Guest windows.

example example
Screen Shot 2021-07-01 at 10 20 14 AM Screen Shot 2021-07-01 at 10 20 25 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.37 Chromium: 91.0.4472.124 (Official Build) nightly (x86_64)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS macOS Version 11.4 (Build 20F71)
@stephendonner
Copy link
Author

@spylogsster @rebron @yrliou @kjozwiak I think (once I verify it's fixed on nightly) that we'll want to take an uplift for this in 1.27.x, given it's behaving as expected in 1.26.74, but present in 1.27:

Screen Shot 2021-07-08 at 10 47 29 AM

@stephendonner
Copy link
Author

@spylogsster this is verified on nightly; can you get an uplift going so we can fix this in 1.27.x? Thanks!

@stephendonner
Copy link
Author

Blocked temporarily, until we get a new beta / release-candidate build, for testing. Marking as QA/Blocked.

@LaurenWags
Copy link
Member

Removing QA/Blocked, 1.27.105 is available to check this issue.

@stephendonner
Copy link
Author

stephendonner commented Jul 15, 2021

Verified PASSED using the inline testplan with

Brave 1.27.105 Chromium: 92.0.4515.93 (Official Build) (x86_64)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. set Method to resolve IPFS resources to Gateway in brave://settings/ipfs
  4. do either/both a Private Window / Guest Window
  5. load ipns://en.wikipedia-on-ipfs.org or ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR

Confirmed ipns:// and ipfs:// URIs were blocked, but loaded in regular windows.

ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR

private window guest window private window with Tor
Screen Shot 2021-07-15 at 11 37 04 AM Screen Shot 2021-07-15 at 10 25 05 AM Screen Shot 2021-07-15 at 10 25 24 AM

ipns://en.wikipedia-on-ipfs.org

private window guest window private window with Tor
Screen Shot 2021-07-15 at 11 38 09 AM Screen Shot 2021-07-15 at 11 38 18 AM Screen Shot 2021-07-15 at 11 38 25 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment