Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr92 followup] Fix signing on Windows #16718

Closed
mkarolin opened this issue Jun 30, 2021 · 0 comments · Fixed by brave/brave-core#9294
Closed

[cr92 followup] Fix signing on Windows #16718

mkarolin opened this issue Jun 30, 2021 · 0 comments · Fixed by brave/brave-core#9294
Assignees
@mkarolin
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.27.x - Release

Comments

@mkarolin
Copy link
Contributor

Signing on Windows doesn't work due to sign_binaries.py change to use with for subprocess.Popen.
@mkarolin mkarolin self-assigned this Jun 30, 2021
@mkarolin mkarolin mentioned this issue Jun 30, 2021
Merged
24 tasks
@mkarolin mkarolin mentioned this issue Jun 30, 2021
Merged
24 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Jun 30, 2021
@mkarolin
[cr92 followup] Fixes signing on Windows.
0531029 
Fixes brave/brave-browser#16718
@mkarolin mkarolin added this to the 1.28.x - Nightly milestone Jul 1, 2021
@mkarolin mkarolin mentioned this issue Jul 7, 2021
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging a pull request may close this issue.

[cr92 followup] Fixes signing on Windows. brave/brave-core
2 participants
@LaurenWags @mkarolin