Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Add Custom Tipping Amount feature (Phase 1) #16021

Closed
srirambv opened this issue May 21, 2021 · 3 comments · Fixed by brave/brave-core#14967
Closed

[Android] Add Custom Tipping Amount feature (Phase 1) #16021

srirambv opened this issue May 21, 2021 · 3 comments · Fixed by brave/brave-core#14967
Assignees
@deeppandya @sujitacharya2005
Labels
feature/rewards OS/Android Fixes related to Android browser functionality parity priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@srirambv
Copy link
Contributor

#15006 was implemented on Desktop. Not yet implemented on Android so adding this tracking issue.

cc: @deeppandya @Miyayes @zenparsing

Issue description from #15006

Custom tipping amounts allows users to manually specify how much they would like to tip a Creator. The custom tipping amount option will be in addition to the default suggested tipping amounts.

Please refer to full feature specification.
@srirambv srirambv added feature/rewards QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels May 21, 2021
@srirambv srirambv mentioned this issue May 21, 2021
Closed
@LaurenWags LaurenWags mentioned this issue Jul 8, 2021
Closed
@Miyayes Miyayes added the parity label Aug 18, 2021
@Miyayes Miyayes changed the title Add Custom Tipping Amount feature (Phase 1) [Android] Add Custom Tipping Amount feature (Phase 1) Aug 18, 2021
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 6, 2021
@LaurenWags LaurenWags mentioned this issue Dec 22, 2021
Closed
@Miyayes Miyayes added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 24, 2022
@Saoiray
Copy link

Saoiray commented Mar 9, 2022

Apologies, but does anyone have an ETA for this?

@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Aug 1, 2022
@Miyayes Miyayes mentioned this issue Aug 1, 2022
Closed
5 tasks
@Miyayes
Copy link
Collaborator

Miyayes commented Sep 14, 2022

Apologies, but does anyone have an ETA for this?

Yes, it will be done with #17070, which is almost done.

@Miyayes Miyayes mentioned this issue Sep 23, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Sep 27, 2022
@Miyayes Miyayes closed this as completed Sep 27, 2022
@GeetaSarvadnya
Copy link

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.46.114

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.46.114

@kjozwiak kjozwiak mentioned this issue Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

@sujitacharya2005 sujitacharya2005

Labels
feature/rewards OS/Android Fixes related to Android browser functionality parity priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

New tipping banner UI brave-browser/issues/17070 brave/brave-core
8 participants
@deeppandya @anthonypkeane @Miyayes @srirambv @sujitacharya2005 @GeetaSarvadnya @brave-builds @Saoiray