Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolved] Using Brave Shields to block ads and trackers breaks a few IMDb functionalities #15923

Closed
Tonev opened this issue May 18, 2021 · 1 comment

Comments

@Tonev
Copy link
Contributor

Tonev commented May 18, 2021

Description

Using Brave Shields to block ads and trackers breaks the IMDb functionalities from the screenshots below.

Steps to Reproduce

  1. Turn on Brave Shields to block ads and trackers.
  2. Go to either of IMDb pages from the screenshots below.
  3. Check if any of the marked functionalities work.

Actual result:

https://user-images.githubusercontent.com/20608253/118437947-33a63600-b6ec-11eb-8909-0c7f9318a0c0.png
https://user-images.githubusercontent.com/20608253/118437951-34d76300-b6ec-11eb-894d-cbb962038dea.png
https://user-images.githubusercontent.com/20608253/118437956-36089000-b6ec-11eb-9152-b4731e644340.png

Expected result:

All broken functionalities should work, in my opinion. They have been unblocked in uBlock Origin.

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.24.85 Chromium: 90.0.4430.212 (Official Build) (64-bit)
Revision e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS Windows 7 Service Pack 1 (Build 7601)
JavaScript V8 9.0.257.29
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36
Command Line "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe" --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=PrefetchPrivacyChanges,WebUIDarkMode,PasswordImport,ReducedReferrerGranularity,LegacyTLSEnforced,AutoupgradeMixedContent,WinrtGeolocationImplementation,SafetyTip --disable-features=AutofillServerCommunication,AutofillEnableAccountWalletStorage,TextFragmentAnchor,SignedExchangeSubresourcePrefetch,TabHoverCards,SignedExchangePrefetchCacheForNavigations,SubresourceWebBundles,SharingQRCodeGenerator,DirectSockets,EnableProfilePickerOnStartup,WebOTP,NotificationTriggers,LangClientHintHeader,NetworkTimeServiceQuerying,SafeBrowsingEnhancedProtection,IdleDetection,SafeBrowsingEnhancedProtectionMessageInInterstitials --flag-switches-begin --enable-features=PrefetchPrivacyChanges,WebUIDarkMode,PasswordImport,ReducedReferrerGranularity,LegacyTLSEnforced,AutoupgradeMixedContent,WinrtGeolocationImplementation,SafetyTip,EphemeralStorage --flag-switches-end
Executable Path C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
Profile Path C:\Users\User\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default
Variations 7146a73c-3f4a17df

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

I believe the issue was resolved in uBlock Origin over here:
easylist/easylist@73c4d8b
easylist/easylist@dc7a8db

Unfortunately, I wasn't given an answer whether the changes above will land in Brave later, so I had to open this issue.

@Tonev Tonev changed the title Brave's aggressive mode breaks a few functionalities on IMDb Brave Shields break a few functionalities on IMDb May 18, 2021
@Tonev Tonev changed the title Brave Shields break a few functionalities on IMDb Using Brave Shields to block ads and trackers breaks a few IMDb functionalities May 18, 2021
@Tonev
Copy link
Contributor Author

Tonev commented May 18, 2021

Looks like required changes have been made, closing the issue as resolved.

@Tonev Tonev closed this as completed May 18, 2021
@Tonev Tonev changed the title Using Brave Shields to block ads and trackers breaks a few IMDb functionalities [Resolved] Using Brave Shields to block ads and trackers breaks a few IMDb functionalities May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants