Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes around BraveProxyingURLLoaderFactory #15898

Closed
iefremov opened this issue May 17, 2021 · 5 comments
Closed

Crashes around BraveProxyingURLLoaderFactory #15898

iefremov opened this issue May 17, 2021 · 5 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. crash OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release.

Comments

@iefremov
Copy link
Contributor

https://brave.sp.backtrace.io/p/brave/explore?time=month&filters=((callstack.functions%2Ccontains%2CBraveProxyingURLLoaderFactory)%2C_deleted%3D0%2C(ver%2Cregex%2C%2290%7C91.*%22))&aggregations=((ver%2Cmax)%2C(callstack%2Chead))&

[ 00 ] 0x7fff20470842
[ 01 ] 0x7fff2045021e
[ 02 ] 0x7fff2044f9a8
[ 03 ] 0x7fff2044f7c9
[ 04 ] base::allocator::MallocZoneFunctionsToReplaceDefault()::$_2::__invoke(_malloc_zone_t*, unsigned long)
[ 05 ] base::allocator::MallocZoneFunctionsToReplaceDefault()::$_2::__invoke(_malloc_zone_t*, unsigned long)
[ 06 ] 0x7fff20468dfe
[ 07 ] operator new(unsigned long)
[ 08 ] <name omitted>
[ 09 ] BraveProxyingURLLoaderFactory::InProgressRequest::RestartInternal()
[ 10 ] BraveProxyingURLLoaderFactory::CreateLoaderAndStart(mojo::PendingReceiver<network::mojom::URLLoader>, int, int, unsigned int, network::ResourceRequest const&, mojo::PendingRemote<network::mojom::URLLoaderClient>, net::MutableNetworkTrafficAnnotationTag const&)
[ 11 ] network::mojom::URLLoaderFactoryStubDispatch::Accept(network::mojom::URLLoaderFactory*, mojo::Message*)
[ 12 ] mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message*)
@iefremov iefremov added crash priority/P2 A bad problem. We might uplift this to the next planned release. OS/Android Fixes related to Android browser functionality OS/Desktop labels May 17, 2021
@iefremov
Copy link
Contributor Author

[ 00 ] base::internal::WeakReference::IsValid() const
[ 01 ] base::internal::Invoker<base::internal::BindState<void (net::SystemDnsConfigChangeNotifier::Core::*)(net::DnsConfig const&), base::WeakPtr<net::SystemDnsConfigChangeNotifier::Core> >, void (net::DnsConfig const&)>::Run(base::internal::BindStateBase*, net::DnsConfig const&)
[ 02 ] BraveProxyingURLLoaderFactory::RemoveRequest(BraveProxyingURLLoaderFactory::InProgressRequest*)
[ 03 ] BraveProxyingURLLoaderFactory::InProgressRequest::OnComplete(network::URLLoaderCompletionStatus const&)
[ 04 ] network::mojom::URLLoaderClientStubDispatch::Accept(network::mojom::URLLoaderClient*, mojo::Message*)
[ 05 ] mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept(mojo::Message*)
[ 06 ] mojo::MessageDispatcher::Accept(mojo::Message*)
[ 07 ] mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*)
[ 08 ] mojo::internal::MultiplexRouter::Accept(mojo::Message*)
[ 09 ] mojo::MessageDispatcher::Accept(mojo::Message*)
[ 10 ] mojo::Connector::DispatchMessage(mojo::Message)
[ 11 ] mojo::Connector::ReadAllAvailableMessages()
[ 12 ] mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&)
[ 13 ] base::TaskAnnotator::RunTask(char const*, base::PendingTask*)
[ 14 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
[ 15 ] base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*)

@iefremov
Copy link
Contributor Author

[ 00 ] std::__1::unique_ptr<GURL, std::__1::default_delete<GURL> >::reset(GURL*)
[ 01 ] std::__1::unique_ptr<GURL, std::__1::default_delete<GURL> >::reset(GURL*)
[ 02 ] GURL::~GURL()
[ 03 ] std::__1::__shared_ptr_emplace<brave::BraveRequestInfo, std::__1::allocator<brave::BraveRequestInfo> >::__on_zero_shared()
[ 04 ] BraveProxyingURLLoaderFactory::InProgressRequest::HandleResponseOrRedirectHeaders(base::OnceCallback<void (int)>)
[ 05 ] BraveProxyingURLLoaderFactory::InProgressRequest::OnReceiveResponse(mojo::StructPtr<network::mojom::URLResponseHead>)
[ 06 ] network::mojom::URLLoaderClientStubDispatch::Accept(network::mojom::URLLoaderClient*, mojo::Message*)
[ 07 ] mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept(mojo::Message*)
[ 08 ] mojo::MessageDispatcher::Accept(mojo::Message*)

@iefremov
Copy link
Contributor Author

can be fixed together with #5574

@bsclifton
Copy link
Member

Possibly related #15410

@iefremov
Copy link
Contributor Author

stale

@iefremov iefremov added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label May 14, 2024
@github-project-automation github-project-automation bot moved this to Done in Crashes Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. crash OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants