Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ipfs" should read "IPFS" in "Brave Ipfs Client Updater" in brave://components #15764

Closed
stephendonner opened this issue May 12, 2021 · 5 comments · Fixed by brave/brave-core#8997

Comments

@stephendonner
Copy link

Description

This is a super-minor bug, but "Ipfs" should read "IPFS" in "Brave Ipfs Client Updater" in brave://components

Steps to Reproduce

  1. on nightly, load brave://components
  2. look at Brave Ipfs Client Updater (Windows) - Version: 1.0.3

Actual result:

brave-ads-resources

Expected result:

Should read Brave IPFS Client Updater -- upper-case, as in https://ipfs.io/

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.26.16 Chromium: 91.0.4472.38 (Official Build) nightly (64-bit)
Revision 8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS Windows 10 OS Version 2009 (Build 21376.1)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@JamesThePaladin
Copy link

I'd like to pick this one up if that's okay. I'm just waiting on a build to see if tis fixed.

@srirambv
Copy link
Contributor

@JamesThePaladin assigned the issue to you. Please a PR created for it once you see it fixed on your local build.

@spylogsster
Copy link

seems it is already fixed, let's recheck after updating to 0.9.0 node

@stephendonner
Copy link
Author

seems it is already fixed, let's recheck after updating to 0.9.0 node

Looks like it's still an issue with 0.9.0-rc1.

Screen Shot 2021-06-01 at 17 10 40

@stephendonner
Copy link
Author

Verified FIXED using

Brave 1.27.42 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Screen Shot 2021-06-04 at 1 34 29 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment