Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to allow opt-out of Griffin variations #15711

Closed
iefremov opened this issue May 10, 2021 · 2 comments
Closed

Add setting to allow opt-out of Griffin variations #15711

iefremov opened this issue May 10, 2021 · 2 comments
Assignees
Labels
closed/duplicate Issue has already been reported griffin OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy

Comments

@iefremov
Copy link
Contributor

iefremov commented May 10, 2021

Description

we should add a global toggle to preferences below the P3A preference, that would allow a user to opt-out of receiving new variations from griffin backend. This should not affect the variations master preference in #15229

Designs

This toggle should be located in brave://settings/privacy under the P3A option (for now).

image

@ShivanKaul ShivanKaul added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 22, 2021
@rebron rebron changed the title Allow to opt-out of Griffin variations Add setting to allow opt-out of Griffin variations Jun 25, 2021
@ShivanKaul
Copy link
Collaborator

Given that we're also planning to run user studies where we collect user data through Griffin (https://github.com/brave/security/issues/439), perhaps this user preference could read
Allow staged roll-outs, feature testing and user studies
This anonymized info helps Brave improve security and performance of current and future features.
?
We don't currently have any preferences related to user studies and ISTM that if the user studies we run are going to be based on Griffin, then this would be a good place to control that. It would be even better if we can let users see and opt-out of specific Griffin studies, kinda like Firefox allows via their about:studies.

@iefremov
Copy link
Contributor Author

closing as mostly dupe of #36295 where the discussion actually happens

@iefremov iefremov added the closed/duplicate Issue has already been reported label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported griffin OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy
Projects
Status: Done
Development

No branches or pull requests

4 participants