Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove request body details from Rewards verbose logging #15661

Closed
zenparsing opened this issue May 6, 2021 · 5 comments · Fixed by brave/brave-core#8767
Closed

Remove request body details from Rewards verbose logging #15661

zenparsing opened this issue May 6, 2021 · 5 comments · Fixed by brave/brave-core#8767

Comments

@zenparsing
Copy link

Some URL requests that are made in bat-native-ledger should not have their request body logged at the verbose logging level, and should be logged instead at a higher level. Audit the code for URL request body logging and increase the logging level as necessary.

@kjozwiak
Copy link
Member

kjozwiak commented May 18, 2021

@brave/legacy_qa we won't be able to verify the above on Android until we get #15924 fixed and uplifted into 1.25.x.

@LaurenWags
Copy link
Member

Removing QA/Blocked, this should be available to test on https://github.com/brave/brave-browser/releases/tag/v1.25.64

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 19, 2021
@stephendonner
Copy link

stephendonner commented May 19, 2021

Verified PASSED using brave/brave-core#8767 with build

Brave 1.25.64 Chromium: 90.0.4430.212 (Official Build) beta (x86_64)
Revision e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS macOS Version 11.3.1 (Build 20E241)

Steps:

  1. new profile, launched Brave using --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=5
  2. enabled Enabled Rewards Verbose Logging via brave://flags
  3. went to brave://rewards and clicked on Verify Wallet
  4. authorized Uphold
  5. logged in to Uphold
  6. went to brave://rewards-internals and clicked Refresh to populate logs
  7. searched for both oauth and token just to be sure
  8. confirmed neither were present, together - just tokens for the grant process
  9. downloaded the logs via the Download button and repeated steps 6 & 7
example example example
Screen Shot 2021-05-19 at 9 43 11 AM Screen Shot 2021-05-19 at 9 45 20 AM Screen Shot 2021-05-19 at 9 46 03 AM

Verification passed on


Brave | 1.25.64 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
-- | --
Revision | e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS | Windows 10 OS Version 2004 (Build 19041.985)

ensured that clicking on Refresh correctly populates the empty text field with the log
ensured that clicking on Download log correctly initiates the download process/flow
ensured that *.uphold.com/oauth2/token didn't appear anywhere within the log after connecting to an Uphold account
also searched for oauth2 & oauth2/token within the log as a double check

Example Example Example
image image image

Verification passed on

Brave 1.25.65 Chromium: 91.0.4472.57 (Official Build) (64-bit)
Revision e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS Ubuntu 18.04 LTS

ensured that clicking on Refresh correctly populates the empty text field with the log
ensured that clicking on Download log correctly initiates the download process/flow
ensured that *.uphold.com/oauth2/token didn't appear anywhere within the log after connecting to an Uphold account
also searched for oauth2 & oauth2/token within the log as a double check

image image image

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 19, 2021
@srirambv
Copy link
Contributor

Removing OS/Android label as there is a follow up issue logged for it #15924

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.25.66 x64 build


Verification passed on Samsung Tab A with Android 10 running 1.25.66 x64 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment