Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitch favicons do not always display for VODs #1566

Closed
LaurenWags opened this issue Oct 13, 2018 · 1 comment
Closed

Twitch favicons do not always display for VODs #1566

LaurenWags opened this issue Oct 13, 2018 · 1 comment
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #968. If you watch a Twitch VOD once, the favicon is a generic page icon. If you view another VOD by that same publisher, then the favicon displays the Twitch publisher icon.

Steps to Reproduce

  1. Enable rewards.
  2. View a Twitch VOD.
  3. Go back to Rewards
  4. See generic page icon.
  5. Go back to Twitch and view another VOD by same publisher/creator.
  6. Go back to Rewards.
  7. Now favicon is correct.

Actual result:

See screenshot below. For the two Twitch videos with correct favicons I viewed two VODs to get the favicons. For the Twitch video displaying the generic icon, I only viewed one VOD.
screen shot 2018-10-13 at 5 25 45 pm

Expected result:

Twitch favicon should be the correct one with the first VOD viewing.

Reproduces how often:

easily

Brave version (chrome://version info)

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes, reproduced on Beta
  • Does it reproduce on browser-laptop? n/a

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @NejcZdovc

@LaurenWags LaurenWags added this to the 0.56.x milestone Oct 13, 2018
@NejcZdovc
Copy link
Contributor

dupe of #1521

@NejcZdovc NejcZdovc modified the milestones: 0.56.x, Dupe / Invalid / Not actionable Oct 14, 2018
@NejcZdovc NejcZdovc added the closed/duplicate Issue has already been reported label Oct 14, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

4 participants