Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Sidebar widget is missing its tooltip #15428

Closed
stephendonner opened this issue Apr 21, 2021 · 2 comments · Fixed by brave/brave-core#8769
Closed

Add to Sidebar widget is missing its tooltip #15428

stephendonner opened this issue Apr 21, 2021 · 2 comments · Fixed by brave/brave-core#8769
Assignees
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@stephendonner
Copy link

Description

Add to Sidebar widget is missing its tooltip

Steps to Reproduce

  1. new profile
  2. load brave://flags/#sidebar and enable the sidebar
  3. restart Brave
  4. hover over the ➕ icon/widget on the bottom of the sidebar

Actual result:

There's no tooltip on hover

Screen Shot 2021-04-21 at 2 03 33 PM

Expected result:

Like the other icons/widgets (Brave Together, Crypto Wallets, Bookmarks, History, Experiments) there should probably be a tooltip on hover, for the Add to Sidebar widget/icon

Screen Shot 2021-04-21 at 2 03 42 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.25.33 Chromium: 90.0.4430.85 (Official Build) nightly (x86_64)
Revision 5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS macOS Version 11.2.3 (Build 20D91)
@stephendonner stephendonner added OS/Desktop feature/sidebar Relating to Brave's Sidebar feature labels Apr 21, 2021
@simonhong simonhong self-assigned this Apr 21, 2021
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label May 3, 2021
@simonhong
Copy link
Member

When hovered, we will show add item menu bubble instead of tooltip by brave/brave-core#8769.

@simonhong simonhong added this to the 1.26.x - Nightly milestone May 11, 2021
@stephendonner
Copy link
Author

Verified FIXED using

Brave 1.26.18 Chromium: 91.0.4472.38 (Official Build) nightly (64-bit)
Revision 8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS Windows 10 OS Version 2009 (Build 21376.1)

Steps:

  1. new profile
  2. load brave://flags/#sidebar and enable the sidebar
  3. restart Brave
  4. hover over the ➕ icon/widget on the bottom of the sidebar

Confirmed I got a menu bubble Add to Sidebar with the current tab's site URL available to add to the sidebar

add-to-sidebar-tooltip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants