Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Reduce Uphold minimum BAT user wallet verification requirement to 15 BAT on Android #15196

Closed
Miyayes opened this issue Apr 8, 2021 · 3 comments · Fixed by brave/brave-core#8645

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 8, 2021

Description

Android

Currently, users need to have 25 BAT to verify their user wallet with Uphold. Uphold has approved lowering the verification threshold to 15 BAT as of March 31, 2021.

This issue has been resolved on desktop, but is being broken out separately for Android for development reasons.

Solution

Reduce all relevant wallet verification gating logic to a 15 BAT threshold.

@Miyayes Miyayes added the OS/Android Fixes related to Android browser functionality label Apr 8, 2021
@lubosz
Copy link

lubosz commented Apr 10, 2021

Why does Android require BAT at all to login to your existing wallet? I was able to use "Verify Wallet" on PC to login into an exisiting Uphold account. While on Android, I switched to a new Phone and need to grind 25 BAT to be able to login into my old Uphold account.

In general I am a bit disappointed that Brave has an internal wallet (Metamask), which can't interact with the rewards without Uphold.

@Miyayes
Copy link
Collaborator Author

Miyayes commented Apr 12, 2021

Why does Android require BAT at all to login to your existing wallet? I was able to use "Verify Wallet" on PC to login into an exisiting Uphold account. While on Android, I switched to a new Phone and need to grind 25 BAT to be able to login into my old Uphold account.

This is solved with #13220, which should be landing in v1.25.

@srirambv
Copy link
Contributor

srirambv commented May 17, 2021

Verification passed on OnePlus 6T with Android 10 running 1.25.60 x64 Beta Build

  • Verified clicking on Verify wallet brings up the new modal
  • Verified modal mentions about min 15 BAT
  • Verified able to login to Uphold wallet even if there is no/low balance
  • Verified able to connect to an existing Uphold wallet account on Android
  • Verified if the balance is more than 15 BAT clicking on verify wallet doesn't bring the new info modal

Verification passed on Samsung Tab A with Android 10 running 1.25.60 x64 Beta Build

  • Verified clicking on Verify wallet brings up the new modal
  • Verified modal mentions about min 15 BAT
  • Verified able to login to Uphold wallet even if there is no/low balance
  • Verified able to connect to an existing Uphold wallet account on Android
  • Verified if the balance is more than 15 BAT clicking on verify wallet doesn't bring the new info modal
  • Logged Wallet login modal is stretched beyond the rewards panel #15775 for tablet UI
OnePlus 6T Samsung Tab A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants