Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frequent "blocked by extension" error page #15047

Closed
diracdeltas opened this issue Mar 31, 2021 · 8 comments · Fixed by brave/brave-core#8402
Closed

frequent "blocked by extension" error page #15047

diracdeltas opened this issue Mar 31, 2021 · 8 comments · Fixed by brave/brave-core#8402

Comments

@diracdeltas
Copy link
Member

repros in Beta (1.23.51) but not Stable so appears to be a recent regression, possibly related to #14134. Also does not repro in Chrome with uBlock installed.

STR:

  1. go to https://go.dowjones.com/managepreferences?utm_campaign=Approved_PROMO_20210330_WSJ%20Industry%20Events_WSJ%20RC%20Forum_Biden%20Email_HTML_Email%20B&utm_medium=email&utm_source=Eloqua&elqTrackId=1bd0f252de144d49bf5237cf29c610fa&elq=c3c3a8fecb9943fc9ab1e50d72983d11&elqaid=6923&elqat=1&elqCampaignId=4931
  2. enter any email
  3. check the 'unsubscribe' box at the bottom and submit

Result:
Screen Shot 2021-03-31 at 10 17 25 AM

Expected result:
https://s716031822.t.eloqua.com/e/DefaultFormSubmitConfirmation.aspx should load correctly

@diracdeltas diracdeltas added OS/Desktop webcompat/shields Shields is breaking a website. labels Mar 31, 2021
@diracdeltas
Copy link
Member Author

this seems to be happening fairly frequently in beta. ex: https://bravesoftware.slack.com/archives/C2FQMN4AD/p1616797559085900, https://bravesoftware.slack.com/archives/C3GNZANPR/p1617133973035600?thread_ts=1617125499.033600&cid=C3GNZANPR, and https://bravesoftware.slack.com/archives/C3GNZANPR/p1617194521052200?thread_ts=1617125499.033600&cid=C3GNZANPR.

i encountered it on 50% of emails i tried to unsubcribe from this morning. in one case, reloading the page made the error go away.

@LaurenWags
Copy link
Member

Adding QA/Blocked until this is uplifted to 1.23.x

@kjozwiak
Copy link
Member

kjozwiak commented Apr 6, 2021

@diracdeltas @pes10k @antonok-edm is this specific to desktop or does it need to be verified on android as well?

@pes10k
Copy link
Contributor

pes10k commented Apr 6, 2021

I saw it on desktop frequently, i do not know if it showed up on Android (though i expect it did bc of the implementation). @antonok-edm since you did the fix, maybe you can confirm?

@antonok-edm
Copy link
Collaborator

@kjozwiak this has occurred on Android as well.

@kjozwiak kjozwiak added OS/Android Fixes related to Android browser functionality QA/Test-All-Device-Types QA/Test-All-Platforms labels Apr 6, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Apr 6, 2021

Thanks 👍 Added OS/Android so this gets checked on android. I also added both QA/Test-All-Device-Types & QA/Test-All-Platform as this is something we'll probably want to check on all platforms. @pes10k @antonok-edm please change if you feel differently re: checking on all the platforms.

@antonok-edm
Copy link
Collaborator

This shouldn't need any testing on iOS, but otherwise that sounds good 👍

@srirambv
Copy link
Contributor

srirambv commented Apr 7, 2021

Verification passed on OnePlus 6T with Andriod 10 running 1.23.66 x64 Beta build


Verification passed on Samsung Tab A with Andriod 10 running 1.23.66 x64 Beta build


Verified PASSED using

Brave 1.23.66 Chromium: 89.0.4389.114 (Official Build) beta (x86_64)
Revision 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS macOS Version 11.2.3 (Build 20D91)
Screenshots Screen Shot 2021-04-07 at 11 58 29 AM | Screen Shot 2021-04-07 at 12 02 33 PM | Screen Shot 2021-04-07 at 12 00 52 PM | Screen Shot 2021-04-07 at 12 00 31 PM

Verification passed on

Brave | 1.23.68 Chromium: 90.0.4430.51 (Official Build) (64-bit)
-- | --
Revision | 32e5fa33a31641bded70a90e60121060691e7125-refs/branch-heads/4430@{#927}
OS | Windows 10 OS Version 2004 (Build 19041.867)

Disable brave-domain-block
image image image
Enable brave-domain-block
image image image
  • Ensured visiting https://1-1ads.com brings up a "Suspicious site ahead" interstitial with a "Proceed" button when #brave-domain-block is enabled under brave://flags
Screenshots
image image

Verified passed with

Brave	1.23.69 Chromium: 90.0.4430.61 (Official Build) (64-bit)
Revision	dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS	Linux

Reproduced the issue using STR from description and test plan from PR on 1.23.51.

1.23.51 - Reproduced examples:

Example - STR Example - PR test plan
1 23 51 - STR - reproduced 1 23 51 - PR - reproduced

Verified the STR from description when #brave-domain-block flag is default, enabled, and disabled.

Default Enabled Disabled
1 23 69 - STR - flag is default 1 23 69 - STR - flag is enabled 1 23 69 - STR - flag is disabled

Verified the test plan from brave/brave-core#8402 when #brave-domain-block flag is default, enabled, and disabled.

Default Enabled Disabled
1 23 69 - PR - flag is default 1 23 69 - PR - flag is enabled 1 23 69 - PR - flag is disabled
1 23 69 - 1-1ads - flag is default 1 23 69 - 1-1ads - flag is enabled 1 23 69 - 1-1ads - flag is disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment