Add Custom Tipping Amount feature (Phase 1) #15006

Miyayes · 2021-03-29T21:51:29Z

Description

Custom tipping amounts allows users to manually specify how much they would like to tip a Creator. The custom tipping amount option will be in addition to the default suggested tipping amounts.

Please refer to full feature specification.

LaurenWags · 2021-05-17T11:51:36Z

@zenparsing @Miyayes is there a spec and test plan for this issue? marking as QA/Blocked until this is sorted.

Miyayes · 2021-05-17T15:47:05Z

Shared spec with the team. Let me know if anything else is needed!

GeetaSarvadnya · 2021-05-18T08:11:15Z

Verification passed on

Brave | 1.25.60 Chromium: 90.0.4430.212&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

Custom Tip via Rewards BAT - One time Tip

Confirmed Custom tip amount link is shown in the tipping banner
Confirmed user can enter a whole number or 2 decimal values in the BAT text box
Confirmed USD value is shown for the entered BAT value
Confirmed entered tipping amount is rounded to closest multiple of 0.25
Confirmed user can swap the BAT and USD values (Encountered BAT --> USD oddities with custom tipping #15908 (comment))
Confirmed user can send one-time custom tips and wallet balance is shown correctly
Confirmed one-time custom tips are shown in Tips panel, summary, BR panel, publisher info table in DB, monthly statement and brave://rewards internal pages.
Confirmed Tokens are redeemed correctly in DB for the one time custom tip

Custom Tip flow:

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Custom Tip display in various places:

`Tips panel`	`Summary`	`BR panel`	`Monthly statement`	`Rewards internal page`	DB file1	DB file2	Token redemption in DB

Custom Tip via Rewards BAT - Recurring Tip

Confirmed Custom tip amount link is shown in the tipping banner
Confirmed user can enter a whole number or 2 decimal values in the BAT text box
Confirmed USD value is shown for the entered BAT value
Confirmed entered tipping amount is rounded to closest multiple of 0.25
Confirmed user can swap the BAT and USD values (Encountered BAT --> USD oddities with custom tipping #15908 (comment))
Confirmed user can send recurring custom tips and wallet balance is shown correctly
Confirmed recurring Tip appeared in the Monthly contribution dropdown in the BR panel
Confirmed recurring custom tips are shown in Monthly contributions panel, summary, BR panel, publisher info table in DB, monthly statement and brave://rewards internal pages.
Confirmed Tokens are redeemed correctly in DB for the recurring custom tip
Encountered and logged Recurring custom tips allows exponential values #15931

Custom Tip flow:

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Custom Tip display in various places:

`Monthly contributions panel`	`Summary`	`BR panel`	`Monthly statement`	`Rewards internal page`

DB Validations:

DB file1	DB file2	Tokens file	Tokens file	Tokens file	Tokens file	Tokens file	Tokens file

Custom Tip via Uphold BAT - One time Tip

Confirmed Custom tip amount link is shown in the tipping banner
Confirmed user can enter a whole number or 2 decimal values in the BAT text box
Confirmed USD value is shown for the entered BAT value
Confirmed entered tipping amount is rounded to closest multiple of 0.25
Confirmed user can swap the BAT and USD values (Encountered BAT --> USD oddities with custom tipping #15908 (comment))
Confirmed user can send one-time custom tips and wallet balance is shown correctly
Confirmed one-time custom tips are shown in Tips panel, summary, BR panel, publisher info table in DB, monthly statement and brave://rewards internal pages.
Confirmed Transactions list in uphold shows the correct 5% and 95% contribution amount

Custom Tip flow:

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Custom Tip display in various places:

`Tips panel`	`Summary`	`BR panel`	`Monthly statement`	`Rewards internal page`

DB Validations

DB file1	DB file2

Uphold Transaction list

Custom Tip via Uphold BAT - Recurring Tip

Confirmed Custom tip amount link is shown in the tipping banner
Confirmed user can enter a whole number or 2 decimal values in the BAT text box
Confirmed USD value is shown for the entered BAT value
Confirmed entered tipping amount is rounded to closest multiple of 0.25
Confirmed user can swap the BAT and USD values (Encountered BAT --> USD oddities with custom tipping #15908 (comment))
Confirmed user can send recurring custom tips and wallet balance is shown correctly
Confirmed recurring Tip appeared in the Monthly contribution dropdown in the BR panel
Confirmed recurring custom tips are shown in Monthly contributions panel, summary, BR panel, publisher info table in DB, monthly statement and brave://rewards internal pages.
Confirmed Transactions list in uphold shows the correct 5% and 95% contribution amount
Encountered and logged Recurring custom tips allows exponential values #15931

Custom Tip flow:

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Custom Tip display in various places:

`Monthly contributions panel`	`Summary`	`BR panel`	`Monthly statement`	`Rewards internal page`

DB Validations

DB file1	DB file2

Uphold Transaction list

Custom Tip via Ad grants - One time Tip

Confirmed Custom tip amount link is shown in the tipping banner
Confirmed user can enter a whole number or 2 decimal values in the BAT text box
Confirmed USD value is shown for the entered BAT value
Confirmed entered tipping amount is rounded to closest multiple of 0.25
Confirmed user can swap the BAT and USD values (Encountered BAT --> USD oddities with custom tipping #15908 (comment))
Confirmed user can send one-time custom tips and wallet balance is shown correctly
Confirmed one-time custom tips are shown in Tips panel, summary, BR panel, publisher info table in DB, monthly statement and brave://rewards internal pages.
Confirmed Tokens are redeemed correctly in DB for the one time custom tip

Custom Tip flow:

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Custom Tip display in various places:

`Tips panel`	`Summary`	`BR panel`	`Monthly statement`	`Rewards internal page`

DB Validations

DB file1	DB file2	unblinded tokens table

Custom Tip via Ad grants - Recurring Tip

Confirmed Custom tip amount link is shown in the tipping banner
Confirmed user can enter a whole number or 2 decimal values in the BAT text box
Confirmed USD value is shown for the entered BAT value
Confirmed entered tipping amount is rounded to closest multiple of 0.25
Confirmed user can swap the BAT and USD values (Encountered BAT --> USD oddities with custom tipping #15908 (comment))
Confirmed user can send recurring custom tips and wallet balance is shown correctly
Confirmed recurring Tip appeared in the Monthly contribution dropdown in the BR panel
Confirmed recurring custom tips are shown in Monthly contributions panel, summary, BR panel, publisher info table in DB, monthly statement and brave://rewards internal pages.
Confirmed Tokens are redeemed correctly in DB for the recurring custom tip
Encountered and logged Recurring custom tips allows exponential values #15931

Custom Tip flow:

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Custom Tip display in various places:

`Monthly contributions panel`	`Summary`	`BR panel`	`Monthly statement`	`Rewards internal page`

DB Validations

DB file1	DB file2	unblinded tokens table

Custom Tip UI and Tip amount less than 0.25 BAT validations

Confirmed default custom tipping UI is shown correctly as mentioned in the Figma spec https://www.figma.com/file/LX0znGgbZ6iL0qvStIwqs8/custom-tip-amount?node-id=1%3A2
Confirmed user defined BAT is shown correctly in the Custom Amount UI
Confirmed You are about to tip text is shown in the pre-confirmation screen
Confirmed user defined BAT is shown correctly in the pre-confirmation screen
Confirmed click on close (X) icon in the You are about to tip screen closes the custom tip page
Confirmed custom tip confirmation UI is shown correctly as mentioned in the Figma spec
Confirmed user defined BAT is shown correctly in the custom tip confirmation UI
Confirmed Tweet about your support link is shown in the custom tip confirmation screen
Confirmed click on `Tweet about your support 'redirects to twitter login page
Confirmed Minimum tip amount is 0.25 BAT message is shown in Tipping banner when user enter any value which is less than the 0.25 BAT.

Custom Tip for Default tip banner pubs

Confirmed custom tipping works fine for default tipping banner pubs like, reddit, github, YT, Twitter and Twitch pubs

Custom Tip flow:

Reddit

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Youtube

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Confirmed onetime tip and monthly custom tips sent to default tipping pubs are processed and shown in Tips panel and Monthly contributions panel

Tips panel	Monthly contribution panel

Covered onetime/recurring Tips for default tipping banner for GH/Twitter/Twitch pubs in gif file

Custom Tip for Custom tip banner pubs

Confirmed custom tipping works fine for custom tipping banner pubs like, reddit, github, YT, Twitter and Twitch pubs

Custom Tip flow:

YT

`Example`	`Example`	`Example`	`Example`	`Example`

GH

`Example`	`Example`	`Example`	`Example`	`Example`

Vimeo

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Confirmed onetime tip and monthly custom tips sent to default tipping pubs are processed and shown in Tips panel and Monthly contributions panel

Tips panel	Monthly contribution panel

Covered onetime/recurring Tips for custom tipping banner for Reddit/Twitter/Twitch pubs in gif file

Custom Tip for Unverified pubs

Confirmed custom tip amount are shown for unverified pubs also
Confirmed one-time custom tips sent to unverified pubs are sent to the pending contribution table
Confirmed recurring custom tips sent to unverified pubs are sent to the pending contribution table

Custom Tip for upgrade profile

Installed 1.24.x and send one-time tips to few verified pubs
Setup recurring tips for few verified pubs
Upgraded the profile to 1.25.x
Confirmed new UI for Custom tip amounts are shown in tipping banner after upgrade
Confirmed recurring tip which is setup in 1.24.x is shown in the Monthly contribution dropdown for the pubs
Confirmed recurring tip can be changed via custom recurring tipping amount
Confirmed changed recurring tip is processed and shown in the summary, BR panel, monthly statement and rewards internal page
Confirmed custom tips works fine for existing pubs in an upgraded profile
Confirmed custom tips one-time/recurring works fine for new pubs in an upgraded profile

Added gif for upgrade profile verifications

Custom tip via Inline Tip

via Github Inline Tip

Confirmed click on Inline Tip for GH pubs navigated to custom tipping new UI
Confirmed custom tipping onetime/recurring works as expected

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

via Reddit Inline Tip

Confirmed click on Inline Tip for GH pubs navigated to custom tipping new UI
Confirmed custom tipping onetime/recurring works as expected

`Example`	`Example`	`Example`	`Example`	`Example`	`Example`	`Example`

Confirmed onetime tip and monthly custom tips sent to via Inline Tip button are processed and shown in Tips panel and Monthly contributions panel

Tips panel	Monthly contribution panel

Verified passed with

Brave	1.25.62 Chromium: 90.0.4430.212 (Official Build) beta (x86_64)
Revision	e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS	macOS Version 10.15.7 (Build 19H1030)

Issues encountered while testing:

BAT --> USD oddities with custom tipping #15908

General Functionality

Confirmed Custom tip amount link is shown in the tipping banner for unverified, connected, and verified creators

Unverified	Connected	Verified

Confirmed user can enter a value for BAT
Confirmed USD value is shown for the entered BAT value
Confirmed value is truncated to 2 decimal places once focus leaves the field
Confirmed entered tipping amount is rounded down to closest multiple of 0.25
Confirmed able to switch between entering BAT and USD
Confirmed BAT value is shown for the entered USD value
Note - encountered #15908 here
Confirmed able to send or cancel custom tip

Example - entering BAT	Example - truncation	Example - switching	Example - confirmation

Confirmed "minimum amount" messaging is shown when user attempt to tip less than .25 BAT
Confirmed insufficient balance messaging

Example - minimum	Example - insufficient

Scenario 1 - Rewards BAT, One time tip

Confirmed able to do a custom one time tip with anon wallet funded by Rewards BAT.

Tip banner	Banner success message	Tips brave://rewards	wallet summary	Monthly Statement	brave://rewards-internals	database

Confirmed logs showed expected information

[23549:775:0518/125235.941547:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type blinded (amount: 4.25, type: RewardsType::ONE_TIME_TIP)
[23549:775:0518/125235.947062:VERBOSE1:contribution.cc(90)] Queue timer set for 10 s
[23549:775:0518/125235.954857:VERBOSE5:ledger_impl.cc(144)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":"6AphTv.............
> Content Type: application/json; charset=utf-8
[23549:775:0518/125236.220825:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions
> Result: Success
> HTTP Code: 200
> Body:

Scenario 2 - Rewards BAT, Monthly tip

Confirmed able to do a custom monthly tip with anon wallet funded by Rewards BAT

Tip banner	Banner success message	Rewards panel	Monthly Tips brave://rewards	wallet summary	Monthly Statement	brave://rewards-internals	database

Confirmed logs showed expected information

[24036:775:0518/133154.857589:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type blinded (amount: 3.75, type: RewardsType::RECURRING_TIP)
[24036:775:0518/133154.869471:VERBOSE1:contribution.cc(90)] Queue timer set for 31 s
[24036:775:0518/133154.878949:VERBOSE5:ledger_impl.cc(144)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions
> Method: UrlMethod::POST
> Content: {"credentials":[{"publicKey":"6AphTvx................
> Content Type: application/json; charset=utf-8
[24036:775:0518/133155.225811:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions
> Result: Success
> HTTP Code: 200
> Body:

Scenario 3 - Uphold BAT, One time tip

Confirmed able to do a custom one time tip with KYC Uphold wallet funded by Uphold BAT.

Tip banner	Banner success message	Tips brave://rewards	wallet summary	Monthly Statement	brave://rewards-internals	database

Confirmed logs showed expected information for tip and fee

[24218:775:0518/134217.802182:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type uphold (amount: 2.25, type: RewardsType::ONE_TIME_TIP)
[24218:775:0518/134217.806751:VERBOSE1:contribution.cc(90)] Queue timer set for 22 s
[24218:775:0518/134217.809572:VERBOSE5:ledger_impl.cc(144)] 
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/............./transactions
> Method: UrlMethod::POST
> Content: {"denomination":{"amount":"2.137500","currency":"BAT"},"destination":"........","message":""}
> Content Type: application/json; charset=utf-8
[24218:775:0518/134217.983672:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/........./transactions
> Result: Success
> HTTP Code: 202
> Body: {"createdAt":"2021-05-18T17:42:17.941Z","denomination":{"amount":"2.1375","currency":"BAT".........
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/......../commit
> Method: UrlMethod::POST
> Content Type: application/json; charset=utf-8
[24218:775:0518/134218.538789:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/........./commit
> Result: Success
> HTTP Code: 200
> Body: {"application":{"clientId":"4c2b6...........
[24218:775:0518/134218.539678:VERBOSE1:uphold.cc(247)] Uphold transfer fee timer set for 21 s

[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/......../transactions
> Method: UrlMethod::POST
> Content: {"denomination":{"amount":"0.112500","currency":"BAT"},"destination":"......","message":"5% transaction fee collected by Brave Software International"}
> Content Type: application/json; charset=utf-8
[24218:775:0518/134239.670132:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/........./transactions
> Result: Success
> HTTP Code: 202
> Body: {"createdAt":"2021-05-18T17:42:39.635Z","denomination":{"amount":"0.1125","currency":"BAT".......
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/.........../commit
> Method: UrlMethod::POST
> Content Type: application/json; charset=utf-8
[24218:775:0518/134240.043865:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/............/commit
> Result: Success
> HTTP Code: 200
> Body: {"application":{"clientId":"4c2..........

Scenario 4 - Uphold BAT, Monthly tip

Confirmed able to do a custom monthly tip with KYC Uphold wallet funded by Uphold BAT

Tip banner	Banner success message	Rewards panel	Monthly Tips brave://rewards	wallet summary	Monthly Statement	brave://rewards-internals	database

Confirmed logs showed expected information for tip and fee

[24896:775:0518/160200.399439:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type uphold (amount: 1.75, type: RewardsType::RECURRING_TIP)
[24896:775:0518/160200.405157:VERBOSE1:contribution.cc(90)] Queue timer set for 27 s
[24896:775:0518/160200.408216:VERBOSE5:ledger_impl.cc(144)] 
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/......../transactions
> Method: UrlMethod::POST
> Content: {"denomination":{"amount":"1.662500","currency":"BAT"},"destination":"......","message":""}
> Content Type: application/json; charset=utf-8
[24896:775:0518/160200.533531:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/........./transactions
> Result: Success
> HTTP Code: 202
> Body: {"createdAt":"2021-05-18T20:02:00.495Z","denomination":{"amount":"1.6625","currency":"BAT".........
[24896:775:0518/160200.535006:VERBOSE5:ledger_impl.cc(144)] 
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/........./commit
> Method: UrlMethod::POST
> Content Type: application/json; charset=utf-8
[24896:775:0518/160200.871733:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/......./transactions/......./commit
> Result: Success
> HTTP Code: 200
> Body: {"application":{"clientId":"4c........
[24896:775:0518/160200.872756:VERBOSE1:uphold.cc(247)] Uphold transfer fee timer set for 65 s

[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/........./transactions
> Method: UrlMethod::POST
> Content: {"denomination":{"amount":"0.087500","currency":"BAT"},"destination":".......","message":"5% transaction fee collected by Brave Software International"}
> Content Type: application/json; charset=utf-8
[24896:775:0518/160306.301704:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/......../transactions
> Result: Success
> HTTP Code: 202
> Body: {"createdAt":"2021-05-18T20:03:06.112Z","denomination":{"amount":"0.0875","currency":"BAT"......... 
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/........./commit
> Method: UrlMethod::POST
> Content Type: application/json; charset=utf-8
[24896:775:0518/160306.589948:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/....../transactions/........./commit
> Result: Success
> HTTP Code: 200
> Body: {"application":{"clientId":"4c2............

Scenario 5 - bitFlyer BAT, One time tip

Confirmed able to do a custom one time tip with KYC bitFlyer wallet funded by bitFlyer BAT.

Tip banner	Banner success message	Tips brave://rewards	wallet summary	Monthly Statement	brave://rewards-internals	database

Confirmed logs showed expected information for tip and fee

[25190:775:0518/163237.876485:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type bitflyer (amount: 4.25, type: RewardsType::ONE_TIME_TIP)
[25190:775:0518/163237.880859:VERBOSE1:contribution.cc(90)] Queue timer set for 4 s
[25190:775:0518/163237.882399:VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
[25190:775:0518/163237.884017:VERBOSE5:ledger_impl.cc(144)] 
[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Method: UrlMethod::POST
> Content: {"amount":"4.037500","currency_code":"BAT",..........
> Content Type: application/json; charset=utf-8
[25190:775:0518/163238.886171:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200
> Body: {...............
}
[25190:775:0518/163238.887081:VERBOSE1:bitflyer.cc(208)] Bitflyer transfer fee timer set for 1 s

[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Method: UrlMethod::POST
> Content: {"amount":"0.212500","currency_code":"BAT".........
> Content Type: application/json; charset=utf-8
[25190:775:0518/163240.642929:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200
> Body: {............
}

Scenario 6 - bitFlyer BAT, Monthly tip

Confirmed able to do a custom monthly tip with KYC bitFlyer wallet funded by bitFlyer BAT

Tip banner	Banner success message	Rewards panel	Monthly Tips brave://rewards	wallet summary	Monthly Statement	brave://rewards-internals	database

Confirmed logs showed expected information for tip and fee

[25361:775:0518/164457.521375:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type bitflyer (amount: 3.75, type: RewardsType::RECURRING_TIP)
[25361:775:0518/164457.526511:VERBOSE1:contribution.cc(90)] Queue timer set for 36 s
[25361:775:0518/164457.528018:VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
[25361:775:0518/164457.529662:VERBOSE5:ledger_impl.cc(144)] 
[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Method: UrlMethod::POST
> Content: {"amount":"3.562500","currency_code":"BAT".............
> Content Type: application/json; charset=utf-8
[25361:775:0518/164458.599681:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200
> Body:............
}
[25361:775:0518/164458.600559:VERBOSE1:bitflyer.cc(208)] Bitflyer transfer fee timer set for 57 s

[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Method: UrlMethod::POST
> Content: {"amount":"0.187500","currency_code":"BAT"...............
> Content Type: application/json; charset=utf-8
[25361:775:0518/164556.629199:VERBOSE1:ads_impl.cc(191)] Browser state changed to idle
[25361:775:0518/164556.660115:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200
> Body:.............

Scenario 7 - Confirm custom tipping works from in-line tip button

Twitter

Tip banner	Banner success message	Tips brave://rewards	wallet summary	Monthly Statement	brave://rewards-internals

Reddit

Tip banner	Banner success message	Tips brave://rewards	wallet summary	Monthly Statement	brave://rewards-internals

GitHub

Tip banner	Banner success message	Tips brave://rewards	wallet summary	Monthly Statement	brave://rewards-internals

Verification passed on

Brave	1.25.66 Chromium: 91.0.4472.70 (Official Build) (64-bit)
Revision	fe095368270a32c92959403754bf6fd357dd9953-refs/branch-heads/4472@{#1172}
OS	Ubuntu 18.04 LTS

Issues encountered while testing:

BAT --> USD oddities with custom tipping #15908

General Functionality

Confirmed Custom tip amount link is shown in the tipping banner for unverified, connected, and verified creators

Unverified	Connected	Verified

Confirmed user can enter a value for BAT
Confirmed USD value is shown for the entered BAT value
Confirmed value is truncated to 2 decimal places once focus leaves the field
Confirmed entered tipping amount is rounded down to closest multiple of 0.25
Confirmed able to switch between entering BAT and USD
Confirmed BAT value is shown for the entered USD value
Note - encountered #15908 here
Confirmed able to send or cancel custom tip

Confirmed "minimum amount" messaging is shown when user attempt to tip less than .25 BAT
Confirmed insufficient balance messaging

Example - minimum	Example - insufficient

Scenario 1 - Rewards BAT, One time tip

Confirmed able to do a custom one time tip with anon wallet funded by Rewards BAT.

Confirmed logs showed expected information

[26630:26630:0525/201619.987980:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type blinded (amount: 1.25, type: ONE_TIME_TIP)
[26630:26630:0525/201620.001518:VERBOSE1:contribution.cc(90)] Queue timer set for 0 s
[26630:26630:0525/201620.047694:VERBOSE5:ledger_impl.cc(145)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions
> Method: POST
> Content: {"credentials":[{"publicKey":
> Content Type: application/json; charset=utf-8
[26630:26630:0525/201620.783344:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions
> Result: Success
> HTTP Code: 200

Scenario 2 - Rewards BAT, Monthly tip

Confirmed able to do a custom monthly tip with anon wallet funded by Rewards BAT

Confirmed logs showed expected information

[29164:29164:0525/211932.251514:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type blinded (amount: 4.25, type: RECURRING_TIP)
[29164:29164:0525/211932.260614:VERBOSE1:contribution.cc(90)] Queue timer set for 0 s
[29164:29164:0525/211932.273926:VERBOSE5:ledger_impl.cc(145)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/suggestions
> Method: POST
> Content: {"credentials":[{"publicKey":"6AphTvx13IgxVRG1nljV2ql1Y7
> Content Type: application/json; charset=utf-8
[29164:29164:0525/211932.990214:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v1/suggestions
> Result: Success
> HTTP Code: 200
> Body:

Scenario 3 - Uphold BAT, One time tip

Confirmed able to do a custom one time tip with KYC Uphold wallet funded by Uphold BAT.

Confirmed logs showed expected information for tip and fee

[31127:31127:0525/215413.700410:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type uphold (amount: 1, type: ONE_TIME_TIP)
[31127:31127:0525/215413.708626:VERBOSE1:contribution.cc(90)] Queue timer set for 3 s
[31127:31127:0525/215413.710875:VERBOSE5:ledger_impl.cc(145)] 
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/fbd1546c-6706-4267-9e6c-3eda44945283/transactions
> Method: POST
> Content: {"denomination":{"amount":"0.950000","currency":"BAT"},"destination":"4ba86766-df8c-48f1-8bc5-35f3bbe1675f","message":""}
> Content Type: application/json; charset=utf-8
[31127:31127:0525/215414.371555:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/fbd1546c-6706-4267-9e6c-3eda44945283/transactions
> Result: Success
> HTTP Code: 202

[31127:31127:0525/215423.741886:VERBOSE5:ledger_impl.cc(145)] 
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/fbd1546c-6706-4267-9e6c-3eda44945283/transactions
> Method: POST
> Content: {"denomination":{"amount":"0.050000","currency":"BAT"},"destination":"1b2b466f-5c15-49bf-995e-c91777d3da93","message":"5% transaction fee collected by Brave Software International"}
> Content Type: application/json; charset=utf-8
[31127:31127:0525/215424.023803:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/fbd1546c-6706-4267-9e6c-3eda44945283/transactions
> Result: Success
> HTTP Code: 202

Scenario 4 - Uphold BAT, Monthly tip

Confirmed able to do a custom monthly tip with KYC Uphold wallet funded by Uphold BAT

Confirmed logs showed expected information for tip and fee

[967:967:0525/234326.461972:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type uphold (amount: 1, type: RECURRING_TIP)
[967:967:0525/234326.470747:VERBOSE1:contribution.cc(90)] Queue timer set for 0 s
[967:967:0525/234326.474997:VERBOSE5:ledger_impl.cc(145)] 
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/fbd1546c-6706-4267-9e6c-3eda44945283/transactions
> Method: POST
> Content: {"denomination":{"amount":"0.950000","currency":"BAT"},"destination":"4ba86766-df8c-48f1-8bc5-35f3bbe1675f","message":""}
> Content Type: application/json; charset=utf-8
[967:967:0525/234327.078221:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/fbd1546c-6706-4267-9e6c-3eda44945283/transactions
> Result: Success
> HTTP Code: 202

[ REQUEST ]
[967:967:0525/234439.618515:VERBOSE5:ledger_impl.cc(145)] 
[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/fbd1546c-6706-4267-9e6c-3eda44945283/transactions
> Method: POST
> Content: {"denomination":{"amount":"0.050000","currency":"BAT"},"destination":"1b2b466f-5c15-49bf-995e-c91777d3da93","message":"5% transaction fee collected by Brave Software International"}
> Content Type: application/json; charset=utf-8
[967:967:0525/234440.347736:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/fbd1546c-6706-4267-9e6c-3eda44945283/transactions
> Result: Success
> HTTP Code: 202

Scenario 5 - bitFlyer BAT, One time tip

Confirmed able to do a custom one time tip with KYC bitFlyer wallet funded by bitFlyer BAT.

Confirmed logs showed expected information for tip and fee

[1797:1797:0525/235249.625935:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type bitflyer (amount: 2.5, type: ONE_TIME_TIP)
[1797:1797:0525/235249.649020:VERBOSE1:contribution.cc(90)] Queue timer set for 28 s
[1797:1797:0525/235249.649894:VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
[1797:1797:0525/235249.653325:VERBOSE5:ledger_impl.cc(145)] 
[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Method: POST
> Content: {"amount":"2.375000","currency_code":"BAT","deposit_id":"1a28d5f0-0762-4c69-b9c7-fdab168a3840","dry_run":false,"transfer_id":"0adfbb36-ddbe-4f8c-af99-363da6e0a82f"}
> Content Type: application/json; charset=utf-8
[1797:1797:0525/235256.651960:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data. Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1)
[1797:1797:0525/235256.656835:ERROR:CONSOLE(0)] "Unchecked runtime.lastError: Tabs cannot be edited right now (user may be dragging a tab).", source: chrome-extension://jidkidbbcafjabdphckchenhfomhnfma/_generated_background_page.html (0)
[1797:1797:0525/235256.657821:ERROR:CONSOLE(0)] "Unchecked runtime.lastError: Tabs cannot be edited right now (user may be dragging a tab).", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/_generated_background_page.html (0)
[1797:1797:0525/235259.052772:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200

[1797:1797:0525/235309.978039:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200
> Body: {
  "dry_run": false,
  "currency_code": "BAT",
  "amount": 0.125000,
  "message": null,
  "transfer_status": "SUCCESS",
  "transfer_id": "72e0d6d6-c427-4650-9548-35f71f605eb7"
}

Scenario 6 - bitFlyer BAT, Monthly tip

Confirmed able to do a custom monthly tip with KYC bitFlyer wallet funded by bitFlyer BAT

Confirmed logs showed expected information for tip and fee

[2812:2812:0526/000505.481096:VERBOSE1:contribution.cc(373)] Creating contribution for wallet type bitflyer (amount: 3.5, type: RECURRING_TIP)
[2812:2812:0526/000505.489104:VERBOSE1:contribution.cc(90)] Queue timer set for 1 s
[2812:2812:0526/000505.489817:VERBOSE1:database_server_publisher_banner.cc(142)] Server publisher banner not found
[2812:2812:0526/000505.490634:VERBOSE5:ledger_impl.cc(145)] 
[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Method: POST
> Content: {"amount":"3.325000","currency_code":"BAT","deposit_id":"1a28d5f0-0762-4c69-b9c7-fdab168a3840","dry_run":false,"transfer_id":"c50d043e-6c39-43c1-834e-30437524669e"}
> Content Type: application/json; charset=utf-8
[2812:2812:0526/000506.509355:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200
> Body: {
  "dry_run": false,
  "currency_code": "BAT",
  "amount": 3.325000,
  "message": null,
  "transfer_status": "SUCCESS",
  "transfer_id": "c50d043e-6c39-43c1-834e-30437524669e"
}

[ REQUEST ]
[2812:2812:0526/000527.241933:VERBOSE6:logging_util.cc(136)] 
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/coin/withdraw-to-deposit-id/request
> Result: Success
> HTTP Code: 200
> Body: {
  "dry_run": false,
  "currency_code": "BAT",
  "amount": 0.175000,
  "message": null,
  "transfer_status": "SUCCESS",
  "transfer_id": "5ce4f646-2e59-4342-8308-c46e613b506d"
}

Scenario 7 - Confirm custom tipping works from in-line tip button

Twitter

Reddit

srirambv · 2021-05-19T12:45:32Z

@deeppandya if am not wrong this is not yet available on Android. Can we have a new issue created for Android and remove the label from this one?

srirambv · 2021-05-21T11:14:27Z

Follow up issue #16021 logged for Android and removing label from this one

Miyayes added OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 29, 2021

Miyayes added the feature/rewards label Mar 31, 2021

zenparsing self-assigned this Apr 7, 2021

zenparsing added QA/Yes release-notes/include labels Apr 12, 2021

zenparsing mentioned this issue Apr 12, 2021

Add support for custom tip amounts brave/brave-core#8514

Merged

24 tasks

zenparsing closed this as completed in brave/brave-core#8514 Apr 21, 2021

zenparsing added this to the 1.25.x - Nightly milestone Apr 21, 2021

LaurenWags added QA/Test-All-Platforms QA/Blocked labels May 10, 2021

LaurenWags removed the QA/Blocked label May 17, 2021

LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 18, 2021

GeetaSarvadnya mentioned this issue May 18, 2021

Recurring custom tips allows exponential values #15931

Closed

GeetaSarvadnya added the QA Pass-Win64 label May 18, 2021

LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 18, 2021

srirambv mentioned this issue May 21, 2021

[Android] Add Custom Tipping Amount feature (Phase 1) #16021

Closed

srirambv removed the OS/Android Fixes related to Android browser functionality label May 21, 2021

btlechowski added the QA Pass-Linux label May 25, 2021

btlechowski mentioned this issue May 25, 2021

Allow comma as decimal point for custom tipping #16083

Open

LaurenWags mentioned this issue May 26, 2021

[Desktop] Release Notes for 1.25.x Release #1 #16089

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Custom Tipping Amount feature (Phase 1) #15006

Add Custom Tipping Amount feature (Phase 1) #15006

Miyayes commented Mar 29, 2021

LaurenWags commented May 17, 2021

Miyayes commented May 17, 2021

GeetaSarvadnya commented May 18, 2021 •

edited by btlechowski

Loading

srirambv commented May 19, 2021

srirambv commented May 21, 2021

Add Custom Tipping Amount feature (Phase 1) #15006

Add Custom Tipping Amount feature (Phase 1) #15006

Comments

Miyayes commented Mar 29, 2021

Description

LaurenWags commented May 17, 2021

Miyayes commented May 17, 2021

GeetaSarvadnya commented May 18, 2021 • edited by btlechowski Loading

srirambv commented May 19, 2021

srirambv commented May 21, 2021

GeetaSarvadnya commented May 18, 2021 •

edited by btlechowski

Loading