Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Suspicious site ahead" blocked-content warning message appears for ads #14911

Closed
stephendonner opened this issue Mar 24, 2021 · 7 comments
Closed
Labels
bug closed/duplicate Issue has already been reported OS/Desktop regression webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website.

Comments

@stephendonner
Copy link

stephendonner commented Mar 24, 2021

Description

"Suspicious site ahead" blocked-content warning message appears for ads

Steps to Reproduce

  1. new profile (not necessary, but a good idea, for default settings)
  2. load https://apps.facebook.com/wordswithfriends
  3. log in using Facebook credentials
  4. wait for page to load
  5. click on the Shields icon in the URL bar and disable Shields

Actual result:

Screen Shot 2021-03-23 at 7 39 47 PM

Expected result:

Screen Shot 2021-03-23 at 7 37 54 PM

Reproduces how often:

100%

Brave version (brave://version info)

Reproduces in:

Brave 1.24.14 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.3 (Build 20D91)

(and current beta and dev channels)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc/ @ryanbr @antonok-edm @pes10k (sorry for casting the net wide)

@stephendonner stephendonner added bug webcompat/not-shields-related Sites are breaking because of something other than Shields. regression webcompat/shields Shields is breaking a website. OS/Desktop labels Mar 24, 2021
@antonok-edm
Copy link
Collaborator

cc @pilgrim-brave as well

@stephendonner
Copy link
Author

Regression range is:

Broken:

Brave 1.23.21 Chromium: 89.0.4389.72 (Official Build) nightly (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.3 (Build 20D91)

Fine:

Brave 1.23.20 Chromium: 89.0.4389.72 (Official Build) nightly (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.3 (Build 20D91)

@ryanbr
Copy link

ryanbr commented Mar 24, 2021

I'm not sure if any of these will cause issues, but does this help, by adding to the brave://adblock to see if it makes a difference @stephendonner

###zap-col-left
###zap-300-4
##div[id^="zap-buyNoAds-"]
###wwf-nav_left_native_ads
##.with_native_ads

@stephendonner
Copy link
Author

@ryanbr unforutnately, nope (seems to neither help nor hurt)

Screen Shot 2021-03-25 at 10 18 22 AM

@stephendonner
Copy link
Author

@rebron would you be able to help find an owner for this? 🙏

@pes10k
Copy link
Contributor

pes10k commented Mar 26, 2021

I believe @antonok-edm and @pilgrim-brave are handling this here: #14826

@rebron
Copy link
Collaborator

rebron commented Mar 26, 2021

@stephendonner Looks like we can just dupe to #14826

@stephendonner stephendonner added the closed/duplicate Issue has already been reported label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/duplicate Issue has already been reported OS/Desktop regression webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website.
Projects
None yet
Development

No branches or pull requests

5 participants