Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more granular control of Settings Syncing (Feature Request) #14850

Open
jclark-dot-org opened this issue Mar 20, 2021 · 1 comment
Open
Labels
feature/sync feature-request OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@jclark-dot-org
Copy link

Description

Enabling Syncing of "Settings" covers a lot of ground. Providing more granular control - either "sub-groups" of settings options, or per-setting override, would enable more flexible use cases.

Steps to Reproduce

  1. Enable Sync and add two devices, enabling sync of "Settings"
  2. Change the Search Engine on one device

Actual result:

Settings such as Shields (including per-site exceptions) are synced between machines. The Search Engine changes on all machines.

Expected result:

Shields (including per-site exceptions) are synced between machines, but Search Engine DOES NOT CHANGE on all machines.

Use cases will vary. I personally sync (Bookmarks, Extensions, Settings, Themes), but I need different search engines at work vs. at home. I don't want to lose Shields syncing, so I have to live with unwanted search engine sync.

Reproduces how often:

Always.

Desktop Brave version:

Version 1.21.77 Chromium: 89.0.4389.90 (Official Build) (x86_64)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A
@jclark-dot-org jclark-dot-org added OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 20, 2021
@bsclifton
Copy link
Member

I saw you filed #13555 - that might cover the use-cases mentioned. Default search engine not syncing is specifically captured with #10760

We can keep this open - but I'm not sure it makes sense to expose all of the settings and allow a per-setting toggle
cc: @rebron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/sync feature-request OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants