Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom ad notification fade in/out transition #14811

Closed
tmancey opened this issue Mar 18, 2021 · 3 comments
Closed

Implement custom ad notification fade in/out transition #14811

tmancey opened this issue Mar 18, 2021 · 3 comments

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 18, 2021

No description provided.

@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 18, 2021
@tmancey tmancey self-assigned this Mar 18, 2021
@tmancey tmancey added this to the 1.26.x - Nightly milestone Apr 29, 2021
@tmancey
Copy link
Contributor Author

tmancey commented Apr 29, 2021

Resolved as part of #13132, please test as part of the new custom ad notifications

@btlechowski
Copy link

btlechowski commented Jun 4, 2021

Verification passed on

Brave 1.26.50 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Ubuntu 18.04 LTS

Verified fade in and fade out animations
14811


Verification PASSED using

Brave 1.26.52 Chromium: 91.0.4472.77 (Official Build) beta (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. launched Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3 --variations-server-url=https://no-thanks.invalid --enable-features="AdNotifications<CommandLineStudy" --force-fieldtrials="*CommandLineStudy/Enabled" --force-fieldtrial-params="CommandLineStudy.Enabled:should_show_custom_notifications/true/ad_notification_timeout/0/ad_notification_fade_duration/2000"
  2. waited (to get variations going, not sure if needed, but good step/habit)
  3. shut down & restarted
  4. opened a set of 4+ tabs
  5. waited
  6. moved cursor/pointer

Confirmed the ad faded in on display, and faded out after I clicked the [X] in the upper-right corner.

ads-fade-in3 copy


Verification passed on



<!--StartFragment-->
Brave | 1.26.50 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->


Verified fade in and fade out animations for Ads
Ads fade out animation1

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 14, 2021

Verification is NOT passed on Samsung Galaxy Tab version 10 running brave Beta build Bravemonoarm64 1.26.56.apk

@tmancey tmancey removed the OS/Android Fixes related to Android browser functionality label Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants