"privacy invasive actions" should be "privacy-invasive actions" in malicious-site warning

[stephendonner]

Description

"privacy invasive actions" should be "privacy-invasive actions" in malicious-site warning

Steps to Reproduce

1. in nightly, load http://1-1ads.com/ (or any from https://pgl.yoyo.org/adservers/serverlist.php?hostformat=adblockplus&showintro=1&mimetype=plaintext)
2. look at the warning text

Actual result:

"...privacy invasive actions."

Expected result:

Should read "...privacy-invasive actions." The text snippet is a compound modifier.

See below for an example from our official site copy.

Reproduces how often:

Brave version (brave://version info)

Brave	1.23.41 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
Revision	62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS	macOS Version 11.2.3 (Build 20D91)

[Ayushsunny]

Hello @srirambv Can I work on this issue?

[srirambv]

Assigned the issue to you @Ayushsunny . Please use the PR template when creating the pull request.

[Ayushsunny]

Assigned the issue to you @Ayushsunny . Please use the PR template when creating the pull request.

Thank you so much sir for helping me in the last PR and also in this one for assigning me.
but for this issue, I need more clarification like what exactly I have to do as I am new to open source so please help me sir

[jcsavage2]

Hello! I am also curious about investigating this issue, but I am not able to replicate this error locally. Right now I am running npm start Component, which starts Brave Browser Development. When I try the URLs listed above I only get "site cannot be reached" error. I am not sure if this is because I am not running the correct version of Brave? The steps to reproduce lists that I need to run "nightly". Is this different than the current version I am running? Do you have any developer resources I could reference so that I can load the nightly version and reproduce this error locally? Thank you!

[Ayushsunny]

Hello Sir @srirambv I am not able to find out the location of this code. can you help me please,

[srirambv]

Looks like there is already a PR up for it brave/brave-core#8427.

cc: @mkarolin

[Ayushsunny]

Looks like there is already a PR up for it brave/brave-core#8427.

cc: @mkarolin

Sir but there is a conflict on that commit https://github.com/brave/brave-core/pull/8427/files#diff-6314ab9f5910c0e3dd53f8ac6bf09b584020abe6790abe7ebcdacc5756c5d5f9

that is already solved by me and got merged brave/brave-core#8535 (comment)

[srirambv]

Probably needs a rebase to fix it. cc: @AdamTranquilla

Will leave @mkarolin to check the PR. @Ayushsunny you can check for other issues to contribute as the PR has been open for 20 days

[soham4abc]

I can work on this issue. If possible pls assign @srirambv

[stephendonner]

On desktop, the text for this specific case has changed, so can't be verified there, due to brave/brave-core@f6335b3.

Removing OS/Desktop and adding OS/Android; what should be verified is the in-product UI on Android corresponding to the commit here: https://github.com/brave/brave-core/pull/9312/files.

[srirambv]

Marking the issue as QA/No as this interstitial page is changed as part of #15189 & #15433. Here is what the new page looks like on Android similar to desktop(#15433)

Dark	Light