Default browser message is not wrapped in certain locales

[GeetaSarvadnya]

Description

Default browser message is not wrapped in German locale

Actual result:

default browser message is not wrapped in German locale

Expected result:

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.21.71 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision	3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS	Windows 10 OS Version 2004 (Build 19041.804)

Version/Channel Information:

• Can you reproduce this issue with the current release? NA
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @simonhong @rebron

[LaurenWags]

Also able to reproduce with Spanish (Spain):

Additionally, it looks like Japanese might not be entirely correct either (the message is on 2 lines, not 3):

Other languages (like French) are fine.

Brave | 1.21.71 Chromium: 89.0.4389.72 (Official Build) (x86_64)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | macOS Version 10.15.7 (Build 19H512)

@rebron not sure if there's an easy way to figure out which languages are affected in Transifex, rather than trial and error.

[simonhong]

@LaurenWags The format is determined by grd file like below for US.
As you can see, sentence is separated to 3 lines.
I think translated sentences should also be sperated into multiple lines.
Or, controlling it by adjusting dialog's width.(but it's hard to position sentences exactly to design)

https://github.com/brave/brave-core/pull/7716/files#diff-6314ab9f5910c0e3dd53f8ac6bf09b584020abe6790abe7ebcdacc5756c5d5f9R936

@GeetaSarvadnya @LaurenWags I assume that japaneses sentence is translated with two lines but german sentence is translated to one line.

[LaurenWags]

gotcha, thanks for this info @simonhong - makes sense what is happening then 👍🏻

[simonhong]

@LaurenWags I think we should use fixed width dialog because translated length is vary and some lanuage would be fit with more than 3 lines.

[LaurenWags]

sgtm @simonhong - will let @rebron comment as well.

[GeetaSarvadnya]

Verification passed on

Brave | 1.21.73 Chromium: 89.0.4389.72 (Official Build) (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.804)

• Verified the STR from the description
• Verified that the default browser text message displayed correctly in Germany, France, Spanish, and Japanese locales
  Germany
  

France

Spanish

Japanese

---

Verification passed on

Brave	1.21.73 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision	3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS	Ubuntu 18.04 LTS

• Verified the STR from the description

German

Spanish

Japanese

---

Verified passed with

Brave | 1.21.73 Chromium: 89.0.4389.72 (Official Build) (x86_64)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | macOS Version 10.15.7 (Build 19H512)

German (Germany)	Spanish (Spain)	Japanese (Japan)	French (France)