Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 89.0.4389.69 to Chromium 89.0.4389.72. #14412

Closed
mkarolin opened this issue Mar 1, 2021 · 3 comments · Fixed by brave/brave-core#8095 or #14416
Closed

Upgrade from Chromium 89.0.4389.69 to Chromium 89.0.4389.72. #14412

mkarolin opened this issue Mar 1, 2021 · 3 comments · Fixed by brave/brave-core#8095 or #14416
Assignees
@mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking release-notes/include
Milestone
1.21.x - Release

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Mar 1, 2021

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/89.0.4389.69..89.0.4389.72?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).
@mkarolin mkarolin added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Mar 1, 2021
@mkarolin mkarolin self-assigned this Mar 1, 2021
@kjozwiak kjozwiak added this to the 1.21.x - Release milestone Mar 1, 2021
This was referenced Mar 1, 2021
Merged
Merged
@bbondy bbondy reopened this Mar 1, 2021
@bbondy
Copy link
Member

bbondy commented Mar 1, 2021

re-opening since this is a release/blocking issue on 1.21.x which has not landed on those branches yet.

This was referenced Mar 1, 2021
Merged
Merged
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2021

Closing as brave/brave-core#8099 & #14424 have been merged.

@kjozwiak kjozwiak closed this as completed Mar 2, 2021
@srirambv
Copy link
Contributor

srirambv commented Mar 2, 2021 •
edited by LaurenWags
Loading

Verification passed on the following devices with Android 10 running 1.21.71 x64 build

Verification passed on


Brave | 1.21.71 Chromium: 89.0.4389.72 (Official Build) (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.804)

image

Verification passed on

Brave 1.21.71 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

image

Verified passed with

Brave | 1.21.71 Chromium: 89.0.4389.72 (Official Build) (x86_64)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | macOS Version 10.15.7 (Build 19H512)

Screen Shot 2021-03-02 at 7 52 24 AM

@LaurenWags LaurenWags mentioned this issue Mar 2, 2021
Closed
@kjozwiak kjozwiak mentioned this issue Mar 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking release-notes/include
Projects
None yet
Milestone
1.21.x - Release
7 participants
@bbondy @kjozwiak @srirambv @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin