Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Googletagservices is blocked instead of mocked #1430

Closed
bbondy opened this issue Oct 4, 2018 · 1 comment · Fixed by brave/brave-core#592
Closed

Googletagservices is blocked instead of mocked #1430

bbondy opened this issue Oct 4, 2018 · 1 comment · Fixed by brave/brave-core#592
Assignees
@bbondy
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Oct 4, 2018 •
edited
Loading

Tracking protection gets to it first.

STR make sure this redirects you to a data url in the urlbar:
https://www.googletagservices.com/tag/js/gpt.js
@bbondy bbondy self-assigned this Oct 4, 2018
bbondy added a commit to brave/brave-core that referenced this issue Oct 4, 2018
@bbondy
Mock google tag services instead of blocking it
719f725 
Fix brave/brave-browser#1430
@bbondy bbondy added this to the 1.x Backlog milestone Oct 4, 2018
@bbondy bbondy mentioned this issue Oct 4, 2018
Closed
18 tasks
bbondy added a commit to brave/brave-core that referenced this issue Oct 9, 2018
@bbondy
Change adblock and TP from resource throttle to network delegate
348e2fc 
This also makes it so empty data urls are used by default instead of
blocking.  Empty image data URLs for images.

Fix brave/brave-browser#1430
Fix brave/brave-browser#1118
Fix brave/brave-browser#1428
Fix brave/brave-browser#1362
@bbondy bbondy added the QA/Yes label Oct 9, 2018
@bbondy bbondy mentioned this issue Oct 9, 2018
Merged
18 tasks
@bbondy bbondy modified the milestones: 1.x Backlog, Releasable builds 0.55.x Oct 9, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Oct 13, 2018 •
edited by btlechowski
Loading

Verified passed with

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Verification Passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

image

Verification passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows 7

This was referenced Jul 10, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
4 participants
@bbondy @srirambv @LaurenWags @btlechowski