Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: "Setup Crypo Wallets" button should read "Set up Crypto Wallets" #14179

Closed
stephendonner opened this issue Feb 16, 2021 · 3 comments · Fixed by brave/brave-core#8251
Closed

Comments

@stephendonner
Copy link

Description

"Setup Crypto Wallets" infobar button should read "Set up Crypto Wallets"

Steps to Reproduce

  1. New profile
  2. Load https://homora.alphafinance.io
  3. In the infobar popup, look at the spelling of the button "Setup Crypto Wallets" (setup = noun or past participle; set up is a phrasal verb)

Actual result:

Screen Shot 2021-02-16 at 9 32 23 AM

Expected result:

Should read "Set up Crypto Wallets"

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.22.22 Chromium: 89.0.4389.40 (Official Build) nightly (x86_64)
Revision 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS macOS Version 11.2.1 (Build 20D74)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@srirambv srirambv added feature/user-interface All UI related feature/web3/wallet Integrating Ethereum+ wallet support QA/Yes labels Feb 17, 2021
@bbondy
Copy link
Member

bbondy commented Feb 19, 2021

The plan is to reimplement this as a native wallet that doesn't require an extension install, so this infobar will go away. So therefore I'm deprioritizing this.

@bbondy bbondy added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Feb 19, 2021
@bbondy bbondy added this to the 1.23.x - Nightly milestone Mar 15, 2021
@stephendonner
Copy link
Author

Verified FIXED using nightly build

Brave 1.23.41 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.3 (Build 20D91)

Screen Shot 2021-03-16 at 9 38 11 AM

@srirambv
Copy link
Contributor

srirambv commented Apr 6, 2021

Verification passed on

Brave 1.23.58 Chromium: 89.0.4389.114 (Official Build) beta (64-bit)
Revision 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS Windows 10 OS Version 2009 (Build 19042.867)

image


Verification passed on

Brave 1.23.58 Chromium: 89.0.4389.114 (Official Build) beta (64-bit)
Revision 1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants