[Security] [hackerone] Tor Onion-Location issue

[darkdh]

https://hackerone.com/reports/1089995

[btlechowski]

Verification passed on

Brave	1.20.97 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#7747

Open in Tor (Header is invalid)

Automatically Tor redirect (Header is invalid)

Open in Tor (HTTP host)

Automatically Tor redirect (HTTP host)

---

Verification passed on

Brave | 1.20.97 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Verified test plan from brave/brave-core#7747

Open in Tor (Header is invalid)
opened https://csrf.jp/brave/onion.php in a normal/private/guest tabs/windows and ensured that the Open in Tor button isn't displayed in the URL bar due to the header chrome://restart/

Normal	Private	Guest

Automatically Tor redirect (Header is invalid)

• enabled Automatically redirect .onion sites via brave://settings/extensions
• opened https://csrf.jp/brave/onion.php in a normal/private/guest tabs/windows and ensured that Brave didn't automatically redirect the user to the Tor page due to the header chrome://restart/

Open in Tor (HTTP host)

• Opened http://fmarier.com in a normal/private/guest tabs/windows and ensured that the Open in Tor button isn't displayed in the URL bar due to the header http://ixrdj3iwwhkuau5tby5jh3a536a2rdhpbdbu6ldhng43r47kim7a3lid.onion/index.html

Normal	Private	Guest

Automatically Tor redirect (HTTP host)

• Enabled Automatically redirect .onion sites via brave://settings/extensions
• Opened http://fmarier.com in a normal/private/guest tabs/windows and ensured that Brave didn't automatically redirect the user to the Tor page due to the header http://ixrdj3iwwhkuau5tby5jh3a536a2rdhpbdbu6ldhng43r47kim7a3lid.onion/index.html

Verification passed on

Brave	1.20.97 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 11.1 (Build 20C69)

Open in Tor (Header is invalid)

Automatically Tor redirect (Header is invalid)

Open in Tor (HTTP host)

Automatically Tor redirect (HTTP host)