Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you hover over the Settings, History, or Bookmark shortcut icons in the footer of the NewTab page, the hover effect displays chrome://pathName rather than brave://pathName #13731

Closed
steviecs opened this issue Jan 23, 2021 · 4 comments
Labels
closed/duplicate Issue has already been reported OS/Desktop

Comments

@steviecs
Copy link

Description

If you hover over the Settings, History, or Bookmark shortcut icons in the footer of the NewTab page, the hover effect displays chrome://pathName rather than brave://pathName

Steps to Reproduce

  1. Open a new tab
  2. Hover over the Settings, History, or Bookmark Icon in the bottom right hand corner
  3. Note the hover effect results in chrome://pathname being visible in the bottom left hand corner of the window

Actual result:

image

Expected result:

The hover effect should display brave://pathName

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 1.19.86 Chromium: 88.0.4324.96 (Official Build) (x86_64)

@simonhong
Copy link
Member

@steviecs Duplicated with #2566.
Thanks for reporting.

@steviecs
Copy link
Author

@steviecs Duplicated with #2566.
Thanks for reporting.

Of course - I submitted a PR for it as well - brave/brave-core#7684

@simonhong
Copy link
Member

@steviecs Left some comments on it :)

@steviecs
Copy link
Author

@simonhong thanks! I'll take a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants