Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttons on interstitial page do not work #13544

Closed
LaurenWags opened this issue Jan 13, 2021 · 2 comments · Fixed by brave/brave-core#7585
Closed

buttons on interstitial page do not work #13544

LaurenWags opened this issue Jan 13, 2021 · 2 comments · Fixed by brave/brave-core#7585

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 13, 2021

Description

Found while testing brave/brave-core#6782 (comment)

The "Advanced" and "Proceed with Public Gateway" buttons do not work on 1.19.82. They did work on 1.19.81 (Chromium 87). Chromium 88 was added to 1.19.82, so possibly an issue related to that.

Steps to Reproduce

based on brave/brave-core#6782 (comment)

  1. Clean profile 1.19.82
  2. Visit a page like https://dweb.link/ipfs/bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html and enable IPFS from infobar.
  3. Go to brave://settings/extensions and confirm "Method to resolve IPFS resources" is Local Node and the "IPFS public gateway fallback" switch is off.
  4. turn off your network and visit brave://ipfs
  5. Stop the node, confirm 0 peers are connected
  6. visit ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR
  7. Get interstitial page
  8. Try clicking "Advanced", nothing happens.
  9. Re-enable network
  10. Try clicking "Advanced" and "Proceed with Public Gateway", neither work.

Actual result:

Clicking on "Advanced" and "Proceed with Public Gateway" do nothing.

Expected result:

"Advanced" should show more info and "Proceed with Public Gateway" should load the page using public gateway. Additionally, the "IPFS public gateway fallback" switch should be on in brave://settings/extensions

Reproduces how often:

easily on 1.19.82

Brave version (brave://version info)

Brave 1.19.82 Chromium: 88.0.4324.79 (Official Build) dev (x86_64)
Revision bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS macOS Version 10.15.7 (Build 19H15)

Brave 1.20.76 Chromium: 88.0.4324.79 (Official Build) nightly (x86_64)
Revision bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS macOS Version 10.15.7 (Build 19H15)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes 1.19.x
  • Can you reproduce this issue with the nightly channel? yes, 1.20.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @bbondy @yrliou

@LaurenWags
Copy link
Member Author

Will need a new build to test on 1.19.x, QA/Blocked until we have this uplifted.

@btlechowski
Copy link

btlechowski commented Jan 15, 2021

Verification passed on

Brave 1.19.84 Chromium: 88.0.4324.87 (Official Build) (64-bit)
Revision dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Verified interstitial page is shown
image

Verified clicking Advanced works:
image

Verified Proceed with Public Gateway works:
image

Verified IPFS public gateway fallback is changed to enabled in brave://settings/extensions
image

Verified after enabling network connection, all worked as expected:
image

Logged #13599


Verified passed with

Brave | 1.19.84 Chromium: 88.0.4324.87 (Official Build) (x86_64)
-- | --
Revision | dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
OS | macOS Version 10.15.7 (Build 19H15)

Verified STR from description

Confirmed interstitial page shows when 0 peers connected. Screen Shot 2021-01-15 at 8 59 57 AM
Confirmed clicking "Advanced" shows info. Screen Shot 2021-01-15 at 9 00 05 AM
Confirmed clicking "Proceed with Public Gateway" loads link over gateway. Screen Shot 2021-01-15 at 9 00 50 AM
Confirmed clicking "Proceed with Public Gateway" enables "IPFS public gateway fallback" switch in settings. Screen Shot 2021-01-15 at 9 01 09 AM

Encountered #13599 for light theme only.


Verification passed on

Brave | 1.19.84 Chromium: 88.0.4324.87 (Official Build) (64-bit)
-- | --
Revision | dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Verified STR from the description

Confirmed interstitial page shows when 0 peers connected ![image](https://user-images.githubusercontent.com/38657976/104877298-90345700-597f-11eb-9931-a8b9a1d1d23e.png)
Confirmed clicking "Advanced" shows info. ![image](https://user-images.githubusercontent.com/38657976/104877373-b1954300-597f-11eb-8038-f91e0b8e0a37.png)
Confirmed clicking "Proceed with Public Gateway" loads link over gateway

image

Confirmed clicking "Proceed with Public Gateway" enables "IPFS public gateway fallback" switch in settings.

image

Encountered #13599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants