Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-tab-page should use brave:// URLs #13467

Closed
pes10k opened this issue Jan 11, 2021 · 2 comments
Closed

New-tab-page should use brave:// URLs #13467

pes10k opened this issue Jan 11, 2021 · 2 comments
Labels
closed/duplicate Issue has already been reported

Comments

@pes10k
Copy link
Contributor

pes10k commented Jan 11, 2021

The new tab page has a number of convenience links for brave:// configuration / settings. For example, the "gear / settings" icon in the lower right hand links to chrome://settings; same for bookmarks and history.

These successfully "redirect" to brave://{settings, bookmarks, history}, but it might be nicer to have them be all-brave-all-the-time.

Mainly, to avoid confusion on the part of non-technical users who may not understand the relationship between Chrome and Brave (think of how alarming it might be to a concerned-but-not-technical user who downloaded Brave to get away from Google!).

Also (though less important) it might add to the shine and polish of the product to have more consistency across the system.

Screen Shot 2021-01-10 at 11 28 26 PM

@pes10k pes10k added feature/new-tab polish Nice to have — usually related to front-end/visual tasks feature/settings OS/Desktop labels Jan 11, 2021
@pes10k
Copy link
Contributor Author

pes10k commented Jan 11, 2021

cc: @rebron @bsclifton

@rebron
Copy link
Collaborator

rebron commented Jan 15, 2021

Closing as dupe of #2566. We had a fix in that one but had to revert.

@rebron rebron closed this as completed Jan 15, 2021
@rebron rebron added closed/duplicate Issue has already been reported and removed OS/Desktop branding feature/new-tab feature/settings polish Nice to have — usually related to front-end/visual tasks labels Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

3 participants